[Koha-bugs] [Bug 27895] New: Internal server error when trying to change picup location for a hold with no valid locations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27895

            Bug ID: 27895
           Summary: Internal server error when trying to change picup
                    location for a hold with no valid locations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If 'AllowHoldPolicyOverride' is set to 'Allow' staff can place a hold that has
no allowed pickup locations.

If staff try to alter the pickup location from the patron's record there is an
internal server error

To test:
1 - Set 'Default checkout, hold and return policy' on Admin->Circ rules to
   Hold policy: From home library
   Hold pickup library match: Item's home library
2 - Set  AllowHoldPolicyOverride to Allow
3 - Place an item level hold for a patron on an item from another branch -
there should be a warn while placing, but hold is allowed
4 - Bring up the patron details or checkout page
5 - Click the holds tab
6 - Try to change the hold pickup location
7 - You get an error: There was an error:error Internal Server Error
8 - In logs:
The method Koha::Libraries->branchcode is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 592
Koha::Objects::AUTOLOAD('Koha::Libraries=HASH(0x5631e45dc298)') called at
/kohadevbox/koha/Koha/Hold.pm line 252
Koha::Hold::__ANON__ at /kohadevbox/koha/Koha/Hold.pm line 252
Koha::Hold::is_pickup_location_valid('Koha::Hold=HASH(0x5631e448ae48)',
'HASH(0x5631e45cf638)') called at t/db_dependent/Koha/Hold.t line 203

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.