[Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 117995
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117995
Bug 27114: Use Template Toolkit plugin for Koha plugins hook
'intranet_catalog_biblio_tab'

Review of attachment 117995:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27114&attachment=117995)
-----------------------------------------------------------------

This is a breaking change.. I think..  We'll need to advertise that in the
release notes to prompt plugin authors to update their plugins.

::: Koha/Template/Plugin/KohaPlugins.pm
@@ +166,5 @@
> +        try {
> +            my @newtabs = $plugin->intranet_catalog_biblio_tab();
> +            foreach my $newtab (@newtabs) {
> +                # Add a unique HTML id
> +                my $html_id = 'tab-'. $plugin->{class} . '-' . $newtab->title;

The addition of $plugin->{class} here could cause problems for existing
plugins.. we will need to make sure any in the wild are updated.

-- 
You are receiving this mail because:
You are watching all bug changes.