[Koha-bugs] [Bug 27835] Closed days offsets with one day

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27835

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 118032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118032&action=edit
Bug 27835: Do not count closed day if holiday when calculating fines

Bug 27180 attempted to allow calculating fines on holidays when the calendar
was ignored
but it affected the day when an item would be charged when following the
calendar for fines

The difference seems to be that get_chargeable_units returns 1 if the start
date is yesterday and
today is a holiday. If finesCalendar is set to 'noFinesWhenClosed' then there
should be 0 chargable units

To test:
1 - Checkout an item to a patron, due yesterday
2 - Confirm the circ rules are set to charge .1 per 1 day
3 - perl misc/cronjobs/fines.pl -v
4 - Patron is charged .1
5 - Clear the checkout and fine and recreate
6 - Apply patch
7 - perl misc/cronjobs/fines.pl -v
8 - Patron is charged 0
9 - prove -v t/db_dependent/Circulation/CalcFine.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.