[Koha-bugs] [Bug 27066] Implement hooks for patrons updates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #13)
> (In reply to Katrin Fischer from comment #7)
> > Please document on https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks
> > 
> > Looking at the code and comparing with the similar after_item_action hooks I
> > wonder about the placement in the code.
> > 
> > The implementation on bug 22709 adds the hooks before the logs are written,
> > this adds them after.
> > 
> > I could imagine that plugins could actually change the data, so would result
> > in a different logging result. So I think "before" would be better. What do
> > you think?
> 
> To come back to the original question - do we care if the plugin calls are
> before of after logaction and should we be consistent? :)

The questions are related ;)

If 'before' and 'after' actions don't affect the data of the object.. then they
wont affect the actionlogs call.. so it shouldn't matter if they're before or
after.  Personally.. I prefer to have them as late as possible, so after, but
that's just a style thing.

-- 
You are receiving this mail because:
You are watching all bug changes.