[Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
TODO Missing a test for change in Letters.pm ?

+    ($table eq 'credits'      )    ? "SELECT * FROM accountlines WHERE  
accountlines_id = ?"                         :
+    ($table eq 'debits'       )    ? "SELECT * FROM accountlines WHERE  
accountlines_id = ?"                         :
Not consistent

+        tendered => scalar $input->param('tendered'),
+        change   => scalar $input->param('change')
Please clarify these two parameters?

After reading patch 4 I thought: Atomic update is arguable. Will this work on
adjusted notices? Not sure.
Patch 5 addressed this concern.

Changing status for feedback/follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.