[Koha-bugs] [Bug 26999] "Any library" not translatable on the hold list

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 15 15:11:26 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26999

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 118234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118234&action=edit
Bug 26999: (follow-up) Simplify code

Doing
$ git grep pickup_locations_code

shows there's some calculated data that is not actually used anywhere.
We can get rid of it.

This patch also reuses $item_object (which is in the same loop scope) to
avoid an extra DB call.

To test:
1. Run:
   $ git grep pickup_locations_code
=> FAIL: It is only used/set as a comma separated string, inside
request.pl
2. Apply this patch
3. Repeat 1
=> SUCCESS: The unused stuff is not there anymore
4. Open the page for placing some holds
=> SUCCESS: It doesn't explode
5. Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list