[Koha-bugs] [Bug 27957] New: Attributes removed in LDAP

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27957

            Bug ID: 27957
           Summary: Attributes removed in LDAP
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Working on bug 27857 (actually, on the follow-up bug 27956), I found that the
Koha::Patron->extended_attributes setter is used to write the new attributes. 
This happens inside a Koha::Patron::Attribute::Types loop which is used to
determine 'valid' attributes (good).

The problem is 'extended_attributes' actually calls:

$self->extended_attributes->filter_by_branch_limitations->delete;

which deletes the existing attribute. So calling it for setting a single
attribute makes it... delete all the attributes each time!

There's also some funky logic in checkpw_ldap. The $patron object seems to be
retrieved in several places and even inside a loop.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.