[Koha-bugs] [Bug 27977] New: Internal server error when placing hold if previously uploaded records have no item type set

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27977

            Bug ID: 27977
           Summary: Internal server error when placing hold if previously
                    uploaded records have no item type set
 Change sponsored?: ---
           Product: Koha
           Version: 20.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cmurdock at ccfls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This is a weird one.  If a batch of records are uploaded through the Stage MARC
for import tool, and the items have no item type set, an Internal Server Error
happens when staff tries to place a hold on any records cataloged *after* that,
even if they do have an item type set.  I stumbled upon this when staff
imported some barebones "on order" records from Baker & Taylor and forgot to
use the MARC modification template I'd created for them to set the item type,
homebranch, holdingbranch, etc.  Later a staff member at another library
cataloged some items manually and tried placing a hold on one of them and got
the Internal Server Error.

In the logs, I see "Can't call method "notforloan" on an undefined value at
/usr/share/koha/lib/C4/Reserves.pm line 1349" when the ISE occurs.  Also it
doesn't seem to happen every time, but what clued me in was another error when
attempting to place a hold, about an item not having an itemtype set from a
completely unrelated record.  I investigated that and found that it was in the
batch with no item type set.

To reproduce:
- Upload a batch of records with no item type set
- Catalog some additional items
- Try to place a hold on one of the items cataloged in the last step, via the
staff interface (haven't tested with the public catalog)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.