[Koha-bugs] [Bug 20447] Add support for MARC holdings records

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 19 14:02:12 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #420 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
QA tool failures are now fixed. But please note:

>  FAIL	installer/data/mysql/kohastructure.sql
>    FAIL	  boolean_vs_tinyint
> 		The new column (suppress) for table holdings is using BOOLEAN as type, must be TINYINT(1) instead, see the SQL12 coding guideline

This is false positive, the QA script matches the word "Boolean" in SQL
*comment* which says "Boolean indicating whether [...]".

and also

> FAIL	Koha/Schema/Result/Holding.pm
>   FAIL	  pod coverage
>		POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666

seems false positive as well?

The warning mentioned in comment 314 doesn't happen anymore. Not sure where it
got fixed, maybe Koha::Object handling or DBIX stuff changed.

Before setting this to NSO I think we want to fix the neworderempty.pl page
mentioned in comment 409.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list