[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Joonas Kylmälä from comment #10)
> (In reply to Joonas Kylmälä from comment #9)
> > I noticed there is no update() function for patron attribute. This would be
> > useful in case there is mandatory attributes defined for patrons. Now having
> > to use the overwrite method adds additional processing for the client a)
> > they need to download all attributes and then b) upload all of them
> > modified. I think it is not a blocker however, just a note that we should
> > implement it in future.
> 
> Actually, we cannot user overwrite() even for changing those attributes that
> are mandatory because the code deletes first all the attributes and then
> re-adds them! This also showed that we have no exception thrown when trying
> to delete mandatory attribute.

Good point. But worth its own bug. This is mostly a controller method calling
underlying implementations. Maybe this overwrite all route is not worth in the
end, as it is replicating some current behavior (in the forms, passing all the
attributes back and forth). The solution is to expose a PUT method.

I will add a PUT for individual attributes.

-- 
You are receiving this mail because:
You are watching all bug changes.