[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #21 from David Nind <david at davidnind.com> ---
Hi Alex.

The first patch works, but I ran into problems with the tests (it may be a
sequencing problem with me apply the patches in the wrong order):

1. prove t/db_dependent/Holds.t: tests fail

prove t/db_dependent/Holds.t
t/db_dependent/Holds.t .. 66/68 Argument "" isn't numeric in numeric eq (==) at
/kohadevbox/koha/Koha/Hold.pm line 520.

    #   Failed test 'Cannot renew'
    #   at t/db_dependent/Holds.t line 1295.

    #   Failed test 'Item is on hold'
    #   at t/db_dependent/Holds.t line 1296.
    #          got: undef
    #     expected: 'on_reserve'
Argument "" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Hold.pm
line 520.
Argument "" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Hold.pm
line 520.
Argument "" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Hold.pm
line 520.

    #   Failed test 'Cannot renew'
    #   at t/db_dependent/Holds.t line 1328.

    #   Failed test 'Item is on hold'
    #   at t/db_dependent/Holds.t line 1329.
    #          got: undef
    #     expected: 'on_reserve'
    # Looks like you failed 4 tests of 6.

#   Failed test 'non priority holds'
#   at t/db_dependent/Holds.t line 1333.
t/db_dependent/Holds.t .. 68/68 # Looks like you failed 1 test of 68.
t/db_dependent/Holds.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/68 subtests 

Test Summary Report
-------------------
t/db_dependent/Holds.t (Wstat: 256 Tests: 68 Failed: 1)
  Failed test:  67
  Non-zero exit status: 1

2 t/db_dependent/Hold.t: fails - changing to 34 tests works

  Failed test:  34
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 33 tests but ran 34.

David

-- 
You are receiving this mail because:
You are watching all bug changes.