[koha-commits] updated branch master (df4b588c6e7166a50ca5724fde16e75c2c84d18c)
git repository hosting
gitosis at git.koha.org
Fri Apr 16 06:17:07 CEST 2010
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Koha GitWeb".
The branch, master has been updated
via df4b588c6e7166a50ca5724fde16e75c2c84d18c (commit)
via cfbd0c847eb20a6875a14a7f85b033cb22f0d8d8 (commit)
via 255362e3cfd1532f0d0a79d757b883123159d681 (commit)
via ad3594fded5bc25d8f5e06b5487b1492884b32d8 (commit)
via 5226371ea3e438c2ecf43ef18cbac090fe17c373 (commit)
via bf0eed8d3137c489a15e49bbfdabb86d6cf12bc5 (commit)
via d027e4dcd6264c908ffbf2b5e170e813ab48e081 (commit)
via 3b137922a06e735036b31728e2905f3c3bed0da4 (commit)
via f75cca228a9149b6b1b5cb04f7037879cb465cf1 (commit)
via 20fb798f51ed707bcd4fb7b882313f6cfaac5123 (commit)
from f1709ab663a010ad41108ee29c79b9da6848e42b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit df4b588c6e7166a50ca5724fde16e75c2c84d18c
Merge: f1709ab663a010ad41108ee29c79b9da6848e42b cfbd0c847eb20a6875a14a7f85b033cb22f0d8d8
Author: Galen Charlton <gmcharlt at gmail.com>
Date: Fri Apr 16 00:16:16 2010 -0400
Merge branch 'serials_mods' of git://github.com/colinsc/koha into to-push
Description by Colin Campbell:
A number of commits, subsequent to enabling warnings in C4::Serials and
eradicating errors and removing dead code.
These are extracted from an install branch running at UN FAO in Rome.
Commits have been rebased on current 3.2 HEAD.
These are not major new functionality, but a series of fixes to
eradicate some randomness caused by undefined values. Includes a commit
to fix Licenses in the serials directory.
* 'serials_mods' of git://github.com/colinsc/koha:
Check value is defined before splitting it
Fix FSF Address in directory serials/
Bug 4380 Use syspref to resolve which bib display is used
Remove bottleneck making claims page unuseable
Clean up Pod Documentation
add warnings to Serials.pm
Add Text to claim date column's header
Basic refactoring of serials-edit.pm
Remove unused or unnecessary variables in claims processing
Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
commit cfbd0c847eb20a6875a14a7f85b033cb22f0d8d8
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 22:36:16 2010 +0100
Check value is defined before splitting it
splitting an undef generates a warning
commit 255362e3cfd1532f0d0a79d757b883123159d681
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 20:37:12 2010 +0100
Fix FSF Address in directory serials/
Add License statement to those files lacking it
commit ad3594fded5bc25d8f5e06b5487b1492884b32d8
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 20:04:24 2010 +0100
Bug 4380 Use syspref to resolve which bib display is used
Be consistent with elsewhere in cataloguing
When switching there from serials
TODO Duplicates Code Should be in a common routine
commit 5226371ea3e438c2ecf43ef18cbac090fe17c373
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 17:58:20 2010 +0100
Remove bottleneck making claims page unuseable
While the idea of showing the number of late serials against the
vendor name was nice it does not scale and on large sites selecting claims
was just timing out. Improved the speed of the initial query but have removed
the big query for each user just to get a count.
Check for 0000-00-00 dates so that C4::Dates does not log error
Removed a variable that was never set and the bit of template used
if the impossible happened
commit bf0eed8d3137c489a15e49bbfdabb86d6cf12bc5
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 14:44:39 2010 +0100
Clean up Pod Documentation
Ensured returns were documented
Fixed some language issues
Removed the host of podchecker warnings about missing lists
added a couple of explicit returns when subroutines
'fell off the end' to remove any ambiguity
commit d027e4dcd6264c908ffbf2b5e170e813ab48e081
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 13:28:40 2010 +0100
add warnings to Serials.pm
Change obvious warning generators:
( use of string comparisons in numeric comparison)
( declaration of variable in comnditional )
also some errors caused by undefined values:
abouttoexpire was not checking for undef values
Pass a valid planneddate in generation of next expected
(undef here causes odd results)
Add a basic test script
test is minimal but I fell over a bug this would have caught
commit 3b137922a06e735036b31728e2905f3c3bed0da4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Jan 21 15:27:02 2010 +0000
Add Text to claim date column's header
commit f75cca228a9149b6b1b5cb04f7037879cb465cf1
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 13:16:31 2010 +0100
Basic refactoring of serials-edit.pm
Removed some useless counts from serials-edit / Serials interfaces
Removed old commented out code. Unrequired variables
Reformatted some code so that improving logic can be done
more easily
commit 20fb798f51ed707bcd4fb7b882313f6cfaac5123
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Thu Apr 8 12:46:06 2010 +0100
Remove unused or unnecessary variables in claims processing
Also cleaned the interface to the claims related functions
in C4::Serials so they do not return an extra count variable
moved generation of dropdown to template instead of inline code
-----------------------------------------------------------------------
Summary of changes:
C4/Serials.pm | 536 +++++++-------------
.../prog/en/modules/serials/claims.tmpl | 16 +-
.../prog/en/modules/serials/serials-edit.tmpl | 2 +-
.../en/modules/serials/subscription-detail.tmpl | 2 +-
serials/checkexpiration.pl | 6 +-
serials/claims.pl | 75 ++--
serials/lateissues-excel.pl | 28 +-
serials/member-search.pl | 6 +-
serials/reorder_members.pl | 15 +
serials/routing-preview.pl | 15 +
serials/routing.pl | 6 +-
serials/serials-edit.pl | 460 ++++++++++-------
serials/statecollection.pl | 6 +-
serials/subscription-add.pl | 6 +-
serials/subscription-detail.pl | 22 +-
t/{Output.t => Serials.t} | 6 +-
16 files changed, 575 insertions(+), 632 deletions(-)
copy t/{Output.t => Serials.t} (66%)
mode change 100755 => 100644
hooks/post-receive
--
Koha GitWeb
More information about the koha-commits
mailing list