[koha-commits] main Koha release repository branch new/bug_6893 created. v3.06.00-135-g28ef6c1

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_6893 has been created
        at  28ef6c199bac6bc4064c857f24957081c88ed174 (commit)

- Log -----------------------------------------------------------------
commit 28ef6c199bac6bc4064c857f24957081c88ed174
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date:   Fri Nov 4 14:20:31 2011 +0100

    Bug 6893 : Updates suggestions list when adding orders
    
    A suggestion added through addorder.pl now changes
    to the ORDERED status as initially intended (but so
    far it stayed as ACCEPTED).
    
    This fixes the list of potential suggestions to order,
    the ORDERED ones don't appear anymore.
    
    Bug 6893 : Follow-up: Disabled WHERE clause excluding ORDERED status
    
    In SearchSuggestions, a WHERE clause was excluding the ORDERED
    suggestions from the results. Now replaced with 1=1.
    
    (before 6893 correction, the WHERE clause was excluding the
    STATUS='CLAIMED' suggestions, but this status cannot be found anywhere
    else in the code... so I changed to STATUS='ORDERED' which
    seemed more accurate, but it had impacts on OPAC and some Admin tabs)
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Both patches applied cleanly, sqashed them together after testing.
    
    Tested:
    1) Creating new suggestions
    - from OPAC, shows up in patron account as 'requested', pending in staff
    - from staff, shows up in list of pending suggestions
    Status in database is ASKED
    
    Note: suggestions made from staff for the same patron have suggestedby = 0
    in the database, so are not showing up in the patron account. Is this by
    intention? (if not, I think this is a separate bug)
    
    2) Accepting suggestions
    - from list
    - from edit page
    Status in database is ACCEPTED
    Patron account shows 'Accepted by the library (Bestseller)'
    
    Note: after changing the status from the list, bug 4068 kicks in and
    some tabs and even suggestions are hidden. Going back to the acq start
    page and going back to the suggestions page from there helps.
    
    3) Rejecting suggestions
    - from list
    - from edit page
    Status in database is REJECTED
    Patron account in OPAC shows 'Suggestion declined'
    
    Note: bug 4068 again.
    
    4) Ordering from suggestions
    - new basket
    - ordered 2 accepted suggestions
    SUCCESS! Great improvement:
    - Status in database is now ORDERED
    - Already ordered suggestions no longer show up on list of
      suggestions to order from.
    - Patron account shows 'Ordered by the library (Bestseller)'
    - Suggestion management page shows a new tab 'Ordered'
    - For the suggestion with a valid 'suggestedby' borrowernumber,
      a mail was generated. (bug 7094)
    
    5) Receive ordered suggestions
    - received my ordered suggestions
    This is is not in the scope of this bug, but for documentation:
    - No message was generated to inform the patron
    - Status stays ORDERED
    - Patron account still shows item as ordered, no change to 4)
    
    Looking at the suggestion.tt I think there should be another status
    AVAILABLE.
    216     [% ELSIF (suggestion.suggestiontypelabel == "Available") %]Available
    
    Signing off, fixes bug reported. Danke!
    
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository