[koha-commits] main Koha release repository branch new/bug_6613 created. v3.04.00-225-gc414c11

Git repo owner gitmaster at git.koha-community.org
Wed Jul 20 23:56:55 CEST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_6613 has been created
        at  c414c11d64d2071b3b8ee597807ddd939de0c6ed (commit)

- Log -----------------------------------------------------------------
commit c414c11d64d2071b3b8ee597807ddd939de0c6ed
Author: Ian Walls <ian.walls at bywatersolutions.com>
Date:   Wed Jul 20 11:41:12 2011 -0400

    Bug 6613: CSV basket export columns misaligned
    
    Removes 'line' heading, since it does not correspond to any existing field name, and it pushes the fields
    over by one ('ordernumber' is used to denote the ordernumber).
    
    This patch also optimizes the GetBasketAsCSV subroutine a bit; it removes an unnecessary call to GetBiblioData,
    since the order information retrieved from GetOrders already contains every field in koha.biblio and koha.biblioitems
    
    This patch also removes the explicit sort done by publishercode, since the information returned by GetOrders is
    already ORDER BY'ed, first by publishercode, then by title (there was a FIXME note in GetBasketAsCSV to do this, but
    it's already done, so... :) )
    
    To Test:
    1.  Create a basket with at least three orders:  one from one publishercode, and two from another
    2.  Be sure to leave out any "\n" in your Order Notes, lest you fall prey to bug 6614!
    3.  Export the basket
    4.  You should see the orders sorted first by publishercode, then by title
    5.  Columns should line up correct all the way through
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list