[koha-commits] main Koha release repository branch new/awaiting_qa/bug_5549 created. v3.04.01-301-gf5a3276

Git repo owner gitmaster at git.koha-community.org
Thu Jul 21 01:33:06 CEST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/awaiting_qa/bug_5549 has been created
        at  f5a3276efe3a1fb4f4a39b1fe115303f418cf0b1 (commit)

- Log -----------------------------------------------------------------
commit f5a3276efe3a1fb4f4a39b1fe115303f418cf0b1
Merge: 0699c8a 840b5a6
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Thu Jul 21 11:31:34 2011 +1200

    Merge remote-tracking branch 'colin/rolling_loans' into new/awaiting_qa/bug_5549
    
    Conflicts:
    	installer/data/mysql/updatedatabase.pl
    	koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
    	kohaversion.pl
    	members/members-home.pl
    	misc/translator/po/nb-NO-i-staff-t-prog-v-3002000.po

commit 840b5a6cc4cd73110c82eea95756516f896e27b4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jul 5 16:44:16 2011 +0100

    CalcFine was corrupting due date
    
    Clone the passed duedate as the addition of days was
    corrupting it in calling context causing new account recs
    to be written rather than updating the existing

commit 5e80a40dde994def5750704e83a55e69f15cc255
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 30 17:04:36 2011 +0100

    Refactor fines.pl
    
    Clean code in fines to remove unnecessary complexity
    remove constructs now thought suspect or
    not good pracrice

commit dd8dae48ca18f60d1f93c5ff38f2a6bfb9cad3be
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 28 14:29:23 2011 +0100

    Fix typo in C4::Circulation

commit 38e7ede0244b9c78c0d99040b3380fbe5eba304d
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 24 14:39:12 2011 +0100

    use DateUtils routine for formatting sql date
    
    Also cleanup modules list to reflect those
    actually used

commit 3c62f85c35eec2754d8f3adf93c09ead6c560018
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 24 14:28:22 2011 +0100

    Koha::Calendar::addDate should not loop on -1
    
    Control variable of loop should be absolute value
    to avoid looping when backtracking

commit e8b081a16144882ccb4c30bddb68a27c4071e19d
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 24 11:05:54 2011 +0100

    Fix 'specify due date'
    
    If due date is set generate a proper DateTime object
    for issue procesing

commit 4e8e08c77fdbb1733d7353c1df178b7d85e71337
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 15:13:04 2011 +0100

    returns calling wrong format routine on date
    
    We don't have an orm yet

commit b3d9fbc47e3806fb9609181b1ba62917339e5302
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 14:11:48 2011 +0100

    Daily loans should be due at 23:59
    
    This was failing in one patch through CalcDueDate

commit 6b176813475bbe8316b65a60063ae3d463623c12
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed May 18 11:01:20 2011 -0400

    Fix for Bug 6364 - Display of item availability broken on OPAC detail screen
    
    Owen:
    
    The markup for showing item availability has been moved to an include
    file. The include lacked the scope declaration for the item results
    loop. Adding the scope declaration to the include file means it can't
    be used by other template unless within the same scope, but I'm not
    aware of a better way to do it given the number of variables in use.
    
    Frédéric:
    
    I confirm the bug.
    
    I propose a alternative solution which solve the bug and keep its
    versability-reusability to the include file. With this solution, when including
    item-status.inc, the foreach loop variable name, which can change from template
    to template, is renamed by using a local variable definition: ie a variable
    name specified after file name in the INCLUDE directive, this variable
    temporalily masking any existing variable.
    
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 66d061cef0bf01675abb97cf4f250532984c9da0
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 12:25:55 2011 +0100

    circ/returns needs to import DateUtils

commit 8f226cf069decab2246d392ab626e73250a58336
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 12:10:51 2011 +0100

    Fix a couple of comparisons in C4::Circulation
    
    Changed a string comparison called on an integer
    Deal with case where value is not set without runtime warnings

commit 02b6ffb37374f6f9cca22ae917edd02978fca9ae
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 11:58:09 2011 +0100

    Format due dates in opac
    
    Further change to ensure that where dates are formatted from the
    db form the duedate loses the 23:59

commit 32fa9eff2a942b1d5da222be0b605f0e5ff7d8dc
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 11:35:35 2011 +0100

    Don't confuse the users with an irrelevant time
    
    If the book is due at 23:59 the due time is irrelevant
    and potentially confusing to the user add a DateUtils
    routine that strips that off the returned display date

commit 416c8c769419118500efc3c349e3f0cdf25b2cf1
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 11:05:00 2011 +0100

    move rollingloans.t to db_dependent tests

commit c470e8db5da80b9864afc475c10a86875eb6bc19
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 09:39:38 2011 +0100

    Calendar needed a change array_ref to hash_ref

commit 9b4604b820c34e546a7b5ec4f513d5ed23c4dfdd
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 00:39:26 2011 +0100

    Koha::Calendar needs to accept scalar add_durations

commit 61d2c418ab110733943281bd60401eacd0ee7903
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 23 00:06:29 2011 +0100

    Make Koha::Calendar testable
    
    Add a testing option
    Add a script with tests
    Some simplifications of the logic

commit 00dd39fd082454379f3d41d7faac5bba8fde783c
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 22 18:02:36 2011 +0100

    Fix typo in renewscript

commit 8e85d270049d640a041f125662e69052cf8c97e8
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 22 17:58:25 2011 +0100

    Show time due in opac-detail

commit 853412fca7228d68dcf661285fade78acb3955cd
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 22 17:48:30 2011 +0100

    Add Returned, checkout out time to Patron Circ History

commit fdc4efc4cf0420a07f4fd2babd838d886387f322
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 22 17:30:34 2011 +0100

    Fix a couple of date issues from testing

commit 7d1c4151bffbeb504581338804c005f886eeb6fa
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 22 10:15:30 2011 +0100

    Add Extra Perl Dependencies
    
    Add:
      DateTime::Timezone
      DateTime::Format::DateParse
      DateTime::Set
      DateTime::Event::ICal
      Readonly
      Readonly::XS

commit c81904ebe17839aaf4daac884b2ce4a2c15183ea
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 21 15:06:51 2011 +0100

    Add script to convert  issue_dates

commit 0577ef149ca4ad12eb04775bfda83c9a235648ac
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 21 14:07:41 2011 +0100

    Overdues : Handle some date comparison and display issues

commit 53ae0393dc6351c36af0c9fbdf91bf4c84cbf25b
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 21 12:11:05 2011 +0100

    Sip scripts should handle dt due dates

commit 734dc1a824e381a04d9aaee2bb49da7b7c0d0c60
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 21 11:08:20 2011 +0100

    Let Timestamp do the right thing if passed a DateTime

commit 09f06a7611bf819b7203a8bae8107d6c5b606c54
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jun 20 17:02:49 2011 +0100

    Make Reduce Duedate aware of New Date formats

commit b56067c85ed41b2b151fe571cac6fff284b4333b
Author: Mark Gavillet <mark.gavillet at ptfs-europe.com>
Date:   Wed May 4 12:41:41 2011 +0100

    Decrease loan period on checkout for items with high holds

commit edb513e0837d01cb5b221c952a4c09d4b43f4d8b
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jun 20 15:48:57 2011 +0100

    replace curdate with now in a couple of sql lines
    
    duedate is now datetime and comparing with curdate
    causes a system error

commit 5c7c33772b32ceca015307c4a8a35aadd3e34bd3
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jun 20 15:47:10 2011 +0100

    Fix calculation of duedates in fines.pl and advance_notices.pl
    
    Cleaned up some no longer used parameters in
    Overdues::CalcFine

commit b8e727971fb29eef7c40ded68ffc375223437207
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jun 20 12:08:14 2011 +0100

    Add days_between method to Koha::Calendar

commit cb21a8be800b0c202b9cd79a4d2d6618ccfe1054
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jun 20 10:22:04 2011 +0100

    Format Date in ILSDI::Services to include hhmm

commit 8014325d8fabfb82c9eb7a3f2ca76cc2c53e5357
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 17 16:34:46 2011 +0100

    Duedate formatting : reserves and opac

commit 2a483ad7145020d5fcdb84be75b7dacf41f813dd
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 17 15:02:46 2011 +0100

    Formatting duedates in catalogue scripts

commit a39fc5257ae639a163187acf48d486f56ff11f72
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 17 14:46:35 2011 +0100

    DateUtils add subroutine format_sqldatetime
    
    convenience method for a frequent use of the other
    methods in the module

commit 1ffad327f526388b00e0666ed95e9bb8cd17cb90
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 17 13:02:10 2011 +0100

    Format date with hh:mm in branchoverdues
    
    Also removed am unused date string

commit 2ad1cf0d805c82d6447c5822a9ece829cb609adc
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 17 12:13:47 2011 +0100

    Cannot use CUR_DATE on date_due column
    
    Comparison of CUR_TIME() & datetime gives
    table corrupted error in mysql
    Plus we want to see hourly loans

commit c7ebd4b035e96e12cc20cdf583374c47315e113c
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jun 17 11:32:50 2011 +0100

    overdues display should be hours mins aware

commit 934ce6f0dd5c509d8bb4324497988be9a87247a6
Author: Ian Walls <ian.walls at bywatersolutions.com>
Date:   Thu Jun 16 16:53:17 2011 -0400

    Bug 6512: time missing from item circulation history
    
    Re-enables the display of the seentime in circ/bookcount.tt; a DEFAULT was set, but
    the value was never actually called into the template.
    
    This patch also moves the time to the right side of the date, and removes the ??:?? default,
    because otherwise, it's just silly
    
    Signed-off-by: Ian Walls <ian.walls at bywatersolutions.com>
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 5299001ac3f672aba27caf0b55fd27e3103736c7
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 16 16:45:02 2011 +0100

    GetPendingIssues now returns dt objects
    
    Show due times in addition to dates in using screens

commit 048ba29c8d75a4b52e71edea9cd98049a29d9f97
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 16 14:38:26 2011 +0100

    fix error from merge

commit 6dfb10f37555258e1281c578a319fecb0d9cecc8
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 16 10:40:18 2011 +0100

    Only use DateTime for issues table
    
    Tidied up the module list
    Removed an used subroutine
    Replaced some old C4::Dates code with DateTime calls

commit 88045a1090f8aef85033d3ebda7008a0bff5849e
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 16 10:10:09 2011 +0100

    Handle datetimes on return

commit dd8214a574c83eeb1f7649a106ecef4f3cbf14c4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 15:20:19 2011 +0100

    Be more strict in outputting utf-8
    
    Fixes errors reported by static tests

commit 4a570ac61b989edb60b533c9e44180ffb36dd566
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 13:44:06 2011 +0100

    DateUtils handling odd cases
    
    Really we should not have them but they are in
    existing code. They were not handled 100%
    added appropriate tests

commit 069639dd1da7ebb01b967fb9ade4c77f46d914bb
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 12:53:13 2011 +0100

    Merge old and new DateUtils tests

commit 35854b91e4b5c666338aaa8e7310809efbcd21f0
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 12:15:14 2011 +0100

    Switch on warnings in circ/returns.pl
    
    Removed a compile time warning caused by a void context
    in a bit of too clever obscure code

commit 770c533acb6614a3bb05efa6b36ca7dd890ee03c
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 11:29:11 2011 +0100

    Add Koha directory to testcritic

commit 227178a2c057c77fda152f6784409f9860659802
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 11:18:38 2011 +0100

    Add Tests For Koha::DateUtils
    
    Add testscript for DateUtils
    Add a parameter to override system pref to output_pref not for
    use in calling software (its superfluous) but to enable testing
    of call with different settings

commit 3f5a8ffedf658f231c16efc46697849bc06d9878
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 15 10:17:42 2011 +0100

    Need a testscript for rolling loans

commit 249cfc56375ed575fb6073de775d4e70f8020ba5
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 14 16:45:32 2011 +0100

    GetPendingIssues now returns duedate as a DateTime object
    
    Change the handling/formatting of duedate in those
    scripts calling it

commit 3c888e36be528ac0f5c32709353b870ddab6efe4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 14 15:32:27 2011 +0100

    Get basic 24 Hr loan working

commit 949a484fe865407513e495060db295c53ceaded0
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 14 13:57:44 2011 +0100

    Pass time_zone correctly

commit f81063691656d0dda5bed0cd9873676babff812b
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jun 13 16:31:46 2011 +0100

    Koha::Calendar allow negative offset to addDate

commit a0b58a7a87d85e5bc8add74523ca0ea28c868081
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 8 14:03:33 2011 +0100

    Due Date calculation in issue needs to be HH:MM aware

commit d8d6ac328cf7cb4a01720b7efe7afb8238fd03c3
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jun 8 12:55:33 2011 +0100

    Add DateUtils Module
    
    Wraps DateTime object creation from a string
    as a tool to enable move to dt objects for more
    flexibility

commit 081ff00a19eb0321eb9c8c19bf3cec3017fc1c83
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue May 24 15:00:33 2011 +0100

    Add a timezone object to C4::Context
    
    Will be required by rolling loans to get correct times
    NB the setting of the TZ in mysql has not been changed as
    this appears to rely on $ENV{TZ} being undefined

commit 7e8ba0e7a7a04db44040778b5f362425841119f5
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 7 15:16:00 2011 +0100

    Allow hourly loans to be indicated in the loan rules
    
    Add a column indicating whether we are talking days or hours here
    This work is merely a holding version pending a better version

commit 2cb75bba8d10f305534b39a770c6a2a8ae8784ba
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jun 7 14:34:18 2011 +0100

    use warnings in smart_rules.pl
    
    Fix some careless code redeclaring a variable
    declaring a variable in a condition
    so that these don't generate errors

commit 6cfe5a44db0b2f274e1626c6bf2bf2c9fdad1842
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jun 2 12:26:09 2011 +0100

    Bug 6335 Set branch in sip session
    
    The server returns its branch as the institution in the config file
    However in transactions it will default to the homebranch of the
    sip user which may not be consistent with that. Needs to set branch
    in the session if there is a value in config otherwise statistics and
    behaviour can be wrong (esp in discharge)

commit 7d3aec1a0ac5fdf660fe8fca801da7813dce96b7
Author: Jane Wagner <jwagner at ptfs.com>
Date:   Fri Apr 1 10:28:04 2011 -0400

    Bug 6034 - Shelving cart feature can wipe permanent shelving location in certain circumstances
    
    Bugfix for problems when shelving cart used without In Processing settings
    
    To test, with InProcessingToShelvingCart off, NewItemsDefaultLocation blank,
    and ReturnToShelvingCart on, create a new item.  Check the contents of the
    location and permanent_location fields in its item record -- the same value
    should be in both.  Then run the item through checkin, and look at those fields
    again.  The location field should now be set to CART while permanent_location
    should still have the original value.  After the cart_to_shelf cron job runs
    with the proper timing, check the item record again.  Both location and
    permanent_location should again be identical.

commit c768887d1603c56cfdf2d0e46b35534e16593baf
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Tue Jun 7 23:55:38 2011 +0200

    Bug 6305: Copy enumchron into created serial item
    
    Should work for normal and supplemental issues.
    
    Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>

commit ad72b21ea4d76cb18df7941275b9dbe98106d14e
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Tue Jun 7 23:50:05 2011 +0200

    Bug 6305: Subscriptions can not be edited
    
    This seems to fix the problem with editing existing subscriptions. Please test.
    
    Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>

commit 71a06284f5c34fa185470ebf68537f1570f296d1
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri May 13 11:28:26 2011 +0100

    Bug 6321 Add a 1/4 months frequency
    
    Thanks Stefano Bargioni for the typo fix
    
    Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>

commit 8625a2934d371bdb60240278c93ddff9f85d1af4
Author: Frédéric Demians <f.demians at tamil.fr>
Date:   Sat May 7 08:32:53 2011 +0200

    Bug 6321 Add a 1/4 month frequency
    
    Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>

commit 10325d017ae064cb59499d6a5c25402c921f9d2c
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu May 5 17:06:38 2011 +0100

    Fix typo in members/members-home.pl

commit b35a213501730332ad1bd0893b96de57633070e4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu May 5 15:32:08 2011 +0100

    Bug 6311 check_inst_id was being passed non-existent value
    
    Due to a typo in the hash key check_inst_id in the
    handle_end_patron_session was always logging an error
    as the actual field contents were not being checked
    unlike in other messages

commit c930aa9b53d043c5b556dadef805a2354ab9b283
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Apr 28 14:39:45 2011 +0100

    Bug 6280 : Don't generate invalid SQL in GetPendingIssues
    
    Change to parameter list in GetPendingIssues made it
    callable by an empty list resulting in invalid sql being
    sent to server. As this was occuring on most issues error log
    was filling up. Put safeguard in the routine
    Also don't bother calling when you have no need
    
    Some of the processing was needlessly obscure

commit 505ce08d47f741f536499e6c8026e17edb3915f9
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Sun Jan 9 23:53:05 2011 +0000

    Bug 5605 SIP: Add Support for the Fee Paid Message
    
    Allow fee paid to be supported for those machines which handle it
    
    Development Sponsered by Halton Borough Council

commit 2d377392b531d63e3ee883033fe201de62cb1e3b
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jan 31 18:09:40 2011 +0000

    Bug 2505: Suppress some warnings emitted by members-home.pl
    
    an undefined value in branch and the undef selected
    can generate a large amount of warning noise
    removed unused variable template_name
    corrected address of FSF

commit 1bf1d1e1db917ba2517c36a1f8444b43e66ee5fe
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jan 31 17:38:56 2011 +0000

    Bug 2505 Enable warnings in remaining members scripts

commit dbadb194c819a7daa526d123c128eaeee3c42d9c
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Apr 13 17:21:47 2011 +0100

    Bug 6181: Remove CGI Scolling lists from C4::Budgets
    
    As noted on bug 766 more cases of usage of
    CGI::scrolling_list were imported into C4::Budgets
    Even if we were not trying to remove usage of this
    the C4 modules are not the place to generate markup
    Most of these routines are noise as they are not used in
    any current code but cause confusion and increase
    maintenance overhead. They are removed
    
    The sort dropboxes on order create are the only
    references in current templates to these routines
    they have been replaced by a select list generated
    by the markup.
    They can probably be removed too but their existence
    although the option that causes them to be displayed
    seems unlikely to be set. I've left them pending
    resolution of some of the inconsistencies and
    confusions surrounding Budgts

commit 5bd5f9a39cfd7e0b14e48426bad8be61dcaf1414
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 17:53:22 2010 +0000

    Bug 5453 : Move declarations out of conditionals
    
    Patched for C4 Modules

commit 9163a43b6218e9824e0c34fa564977e2613cbc85
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 15:19:22 2010 +0000

    Bug 5453 Move declarations out of conditionals

commit 7dffc176a33a3db90d928b539ca3ca59fe13ee1a
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 15:15:47 2010 +0000

    Bug 5453 Move declarations out of conditionals in opac

commit 9a9752a251792ec67a9f0106d806e842f5142fa6
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 12:28:36 2010 +0000

    Bug 5453 Move declarations out of conditionals
    
    Fix im members scripts

commit 868f016e63e1953bc3cff2b293f1c95de8994da4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 11:27:57 2010 +0000

    Bug 5453: Move declarations from within conditionals in catalogue/search.pl

commit e8560bca6779d972f57a0c2093370a5eba17946e
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 11:06:48 2010 +0000

    Bug 5453: Move declarations out of conditionals
    
    Patch admin/*.pl scripts

commit e02ffe28521d185f02e7fef3eabe558a5bdc4f60
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Nov 29 10:37:15 2010 +0000

    Bug 5453 Do not declare variables in conditionals
    
    Removed occurences in acqui/*.pl

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list