[koha-commits] main Koha release repository branch new/bug_7073 created. v3.06.00-61-gf56e6c0

Git repo owner gitmaster at git.koha-community.org
Thu Nov 24 11:44:16 CET 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_7073 has been created
        at  f56e6c0a58145ed3a30341bf0df85e17cde0135d (commit)

- Log -----------------------------------------------------------------
commit f56e6c0a58145ed3a30341bf0df85e17cde0135d
Author: Ian Walls <ian.walls at bywatersolutions.com>
Date:   Thu Oct 20 15:54:07 2011 -0400

    Bug 7073: GetCOinSBiblio should take $record object, not biblionumber
    
    This patch changes the GetCOinsBiblio subroutine to take a MARC record object
    (as returned from GetMarcBiblio) instead of a biblionumber.  The first thing the subroutine
    did was GetMarcBiblio, and the $biblionumber passed was never used again.
    
    This subroutine was only used 3 places: opac/opac-search.pl, opac/opac-detail.pl,
    and C4/VirtualShelves/Page.pm.  In the first and last cases, it was used in a loop.
    In the last two cases, a call to GetMarcBiblio had already been done.  This is expensive, and
    we were doing it twice per record.
    
    For opac/opac-search.pl, the call to GetMarcBiblio was moved to just outside GetCOinSBiblio;
    this will not change the performance at all.  But for opac/opac-detail.pl and C4/VirtualShelves/Page.pm,
    a redudant call to GetMarcBiblio is now avoided.
    
    To Test:
    1. Enable COinSinOPACResults in system preferences.  Perform a search in the OPAC.
       Verify that the COinS spans are showing up
    2. View the detail record of one of the returned items.  Confirm that the COinS span exists on the detail page.
    3. View a list in the OPAC.  Confirm that COinS spans are still showing up
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list