[koha-commits] main Koha release repository branch new/enh/bug_5680 created. v3.04.00-752-gdcfb5e6

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/enh/bug_5680 has been created
        at  dcfb5e63c9092efc396da98b51e079efc3b823f9 (commit)

- Log -----------------------------------------------------------------
commit dcfb5e63c9092efc396da98b51e079efc3b823f9
Author: Christophe Croullebois <christophe.croullebois at biblibre.com>
Date:   Sat Oct 15 21:21:35 2011 +0200

    Bug 5680: Follow Up for Order cancelling improvement : the same for parcel.pl
    
    The same scope than in basket.pl
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Detailed information about possible deletion of orders on parcel page.
    
    1) Delete order for record with 1 other item and item level hold
    OK. Record, item and hold remain, only on order item is deleted.
    
    2) Delete order for ordered record with 1 item and title level hold
    OK. Deletion is not possible, before hold is cancelled.
    
    3) Delete order for new record with only items connected to this order
    OK. Cancelling the order deletes record and item or only order,
    depending on link used.
    
    4) Delete order for record with subscription.
    OK. Subscription remains untouched, item is deleted.
    
    Also checked:
    AcqCreateItem = on receive / in cataloging
    Links show and it's possible to delete the order or only the record
    using different links.
    
    Comments:
    There is a table sorter option for the last column with the delete links.
    I am not sure it is useful here, but it does work.
    
    Before patch is applied, the links use 'cancel' instead of 'delete'.
    I am not sure which is better and if it should be different on
    basket summary and order receive or the same on both.
    
    QA Comment:
    Made a small change to template language; blocking deletion because of items referred to
    holds instead.  Changed text to refer to items.
    Signed-off-by: Ian Walls <ian.walls at bywatersolutions.com>
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 4d67e6910775ea389cfa0a25e3fb55b9cf17bd6f
Author: Christophe Croullebois <christophe.croullebois at biblibre.com>
Date:   Tue May 24 16:39:42 2011 +0200

    Bug 5680: Order cancelling improvement : delete attached items & biblio if avalaible
    
    - all items attached to the order are deleted
    - if there is no more items, and if the biblio is not in other orders and no subscriptions and no holds then the biblio is proposed to deletion
    Now whe have 2 links : "delete order" and "delete order and catalog record", the second one appears only if the deletion is possible.
    Note that if an hold is related to the item or if the item is unique for the biblio the link "Delete order" is canceled due to hold remaining.
    On mouse over explanations are shown with count.
    More lines of warnings with count are shown depending of the case.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Configuration:
    AcqCreateItem = on order
    
    Test cases and results:
    
    1) Order new record with 2 items
    a) From basket
    - delete order: only deletes items, OK!
    - delete order and catalog record: deletes record and items, OK
    b) From shipment/receive
    - delete order: only deletes items, OK!
    
    2) Order 1 additional item for existing record with 1 item
    a) From basket:
    - delete order: works, existing item and record remain, OK
    - Can't delete order and catalog record, 1 item left, OK!
    
    3) Order new record with 1 item, title level hold on record
    a) From basket:
    - delete order: not possible, OK!
    - delete orer and catalog record: not possible, OK!
    b) From shipment/receive page
    - Cancel: Deletes order, record and hold silently.
    NO WARNING. NOT OK. See note below.
    
    4) Order 1 additional item for existing record with 1 item,
    item level hold on existing item
    a) From basket:
    - delete order: works, hold and existing item remain, OK!
    - delete order and catalog record: not possible, OK!
    b) From shipment/receive page
    - Cancel: on order item is deleted, other item and hold remain.
    
    5) Order new serial record, create subscription
    a) From basket:
    - delete order: works, record and subscription remain, OK!
    - delete order and catalog record: not possible, OK!
    b) From shipment/receive page:
    - Cancel: Subscription and record are silently deleted. NOT OK.
    
    6) Order additional item for existing record with other on order items
    a) From basket:
    - delete order: works, existing on order items remain, OK!
    - delete order and catalog record: not possible, OK!
    b) From shipment:
    - Cancel: deletes order and ordered item. OK.
    
    Changes made:
    I changed the wording of the error messages a bit in the template.
    I changed the message 'Can't delete order and catalog record' to not be
    shown as a link, as the link does nothing. Tooltip still appears.
    I attached a screenshot to the bug showing some of my changes.
    
    Hope that's ok.
    
    Necessary  enhancements:
    Cancelling orders when receiving items should work the same as from the
    basket summary page. We need the same checks and messages there before
    deleting records and items automatically.
    I am signing off on this, but to go into Koha it  needs a follow-up for the
    order receive page.
    Signed-off-by: Ian Walls <ian.walls at bywatersolutions.com>
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository