[koha-commits] main Koha release repository branch new/bug_8955 created. v3.08.00-1464-ge7cfb39

Git repo owner gitmaster at git.koha-community.org
Sat Dec 22 22:35:25 CET 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_8955 has been created
        at  e7cfb39a66dfc9f5af619ecd78bb757dfe4dec4e (commit)

- Log -----------------------------------------------------------------
commit e7cfb39a66dfc9f5af619ecd78bb757dfe4dec4e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Nov 6 11:14:44 2012 -0500

    Bug 8955 [Follow-up] Self checkout should degrade gracefully w/o JavaScript
    
    This follow-up fixes some instance of unnecessary JavaScript
    which I missed the first time around: The renew and check-in
    buttons on the list of checkouts. The functionality can be
    easily accomplished without JS.
    
    Also corrected:
    
    - Capitalization error
    - Miss-named variable causing the "too many checkouts" not
      to be displayed
    - Misplaced [% END %] tags hidding "Return to account" button
      on some dialogs.
    - Corrected variable scope error which prevented the "return"
      button from appearing.
    
    To test, log into self checkout using an account which has
    checkouts. Testing renewing items both by scanning barcodes
    and by clicking the "renew" button in the list of checkouts.
    
    Renew something until it reaches its limit and test checking
    it out by scanning the barcode. Test the "check in" button.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit e1c621c23098c6d7562dbebf905ff3672d49e04e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Oct 24 11:02:28 2012 -0400

    Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off
    
    Several changes in this patch, the largest of which is that the
    renew/return dialogs no longer require JavaScript in order to properly
    alter and submit the form. Instead each button uses a separate form.
    
    To test, log in to self checkout and submit a barcode which is checked
    out and can be renewd, and a barcode which is checked out but has
    reached the checkout limit. On the resulting dialogs each button
    should function properly.
    
    Also changed: I removed some useless JavaScript processing related
    to a bogus "valid_session" variable which was unused.
    
    Similarly removed is template logic based on a "timedout" variable which
    was not set by the script. Note that the script contains NO server-
    side handling of timeout. Timeout is dependent on JavaScript.
    
    To test these changes, confirm that with JavaScript enabled you are
    automatically logged out after the time specified in the SelfCheckTimeout
    preference.
    
    Other minor changes: Terminology and capitalization corrections,
    minor style tweaks.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list