[koha-commits] main Koha release repository branch new/bug_6875 updated. v3.06.00-562-gdf5405c

Git repo owner gitmaster at git.koha-community.org
Mon Feb 20 16:45:38 CET 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_6875 has been updated
       via  df5405c56e0f89dee44ed1cf1a3a761cf31efe3c (commit)
       via  49b167e8486e19a20f055e1ce9cde30f82cfc55e (commit)
      from  1ddc9322dfc13ef7f1e930692bfd2cb3771b102b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit df5405c56e0f89dee44ed1cf1a3a761cf31efe3c
Author: Paul Poulain <paul.poulain at biblibre.com>
Date:   Fri Sep 16 20:20:37 2011 +0200

    Bug 6875 de-nesting C4::Items
    
    C4::Branch is used only in CheckItemPresave, moving from a use to a require in the sub
    C4::Reserve:
        This package is loaded just for C4::Reserves::CheckReserves called in C4::Items::GetItemsInfo
        The GetItemsInfo stores the result of CheckReserves in a hash entry, count_reserve, that is used only in opac_detail to display the status of a hold. We could remove the reserve_count hash entry and inline C4::Reserves::CheckReserves directly from opac-detail.pl page
        in opac-detail.pl, instead of
        if( $itm->{'count_reserves'} eq "Waiting"){ $itm->{'waiting'} = 1; }
        write :
        if ( C4::Reserves::CheckReserves(<<parameters>>) eq "Waiting"){ $itm->{'waiting'} = 1; }
    C4::Acquisition is used only in MoveItemFromBiblio, a sub that is rarely called. Moving from a use to a require in the sub
    C4::Charset is used only in _parse_unlinked_item_subfields_from_xml. Moving from a use to require in the sub
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Checked opac-detail and cataloging. Code looks good.

commit 49b167e8486e19a20f055e1ce9cde30f82cfc55e
Author: Paul Poulain <paul.poulain at biblibre.com>
Date:   Fri Sep 16 19:37:15 2011 +0200

    Bug 6875 de nesting C4::Biblio
    
    C4::Biblio is used in many many places. The goal of this cleaning is to do from C4::Biblio a package with as many dependancies as possible.
    
    * C4::Heading is called only in 1 place, highly rarely used (only in 1 misc/link_bibs_to_authorities.pl), moving to require
    * PrepareItemrecordDisplay is a sub that is more related to Items, moving it here. It means some scripts that used this sub must be checked against use C4::Items
    * C4::Items is needed in EmbedItemsInMarcBiblio, moving it only in this sub, and switching to require
    * 2 subs are totally useless z3950_extended_services and set_service_options, removing them
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    No test plan included, but tested some opac and cataloging functions.
    Code looks good. Marked as Passed QA.

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                          |  344 +--------------------------------
 C4/Items.pm                           |  255 +++++++++++++++++++++++--
 C4/Serials.pm                         |    5 +-
 acqui/neworderempty.pl                |    1 +
 opac/opac-detail.pl                   |    9 +-
 t/db_dependent/lib/KohaTest/Biblio.pm |    3 -
 t/db_dependent/lib/KohaTest/Items.pm  |    1 +
 7 files changed, 251 insertions(+), 367 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list