[koha-commits] main Koha release repository branch new/bug_6790 created. v3.06.00-405-gd2c24f3

Git repo owner gitmaster at git.koha-community.org
Mon Jan 23 18:07:10 CET 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_6790 has been created
        at  d2c24f3bbff5c3ba96ce5ae8baa2313fabf786d5 (commit)

- Log -----------------------------------------------------------------
commit d2c24f3bbff5c3ba96ce5ae8baa2313fabf786d5
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Aug 26 16:17:11 2011 +0100

    Bug 6790: Remove unnecessary variable from getroutinglist return
    
    getroutinglist returns a count variable to indicate how many elements
    are in the array. This is almost always a serious code smell. (We are
    programming in a list manipulating language) The routine was executing
    am unnecessary loop just to maintain that var.
    Removed the variable from the routine and perldoc
    refactored calls of the routine removed the c-style loops for
    more idiomatic and maintainable for loops
    renamed some opaquely named variables
    removed a call to the routine where nothing was done with the data
    moved some html out of the calling script and into the template
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list