[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.03-18-g708fed2

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  708fed22652af1a9ebf48174a67669563a73ec5f (commit)
       via  e666a29698c29557ae3d3d2a074de0e2dc3e66ae (commit)
      from  71900d9d1088651690013a4413301b0476b5bab9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 708fed22652af1a9ebf48174a67669563a73ec5f
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Fri Jun 15 10:07:22 2012 -0400

    Bug 7943 follow-up: Fix template filename
    
    In preparation for some later work on authorities, the filename for the
    OPAC authority viewer changed.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit e666a29698c29557ae3d3d2a074de0e2dc3e66ae
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Wed May 30 15:20:40 2012 -0400

    Bug 7943: Authority search results are untranslatable
    
    The HTML for authority search results was previously generated in
    C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be
    translated. This patch moves the HTML generation into the templates
    by introducing a new authorities-search-results.inc include file for
    both the OPAC and the Intranet which contains a Template::Toolkit BLOCK
    for rendering the authority results. Fixes the authority autocomplete
    by removing the untranslatable strings, and returning only data from
    the database.
    
    To test:
    1. Apply patch.
    2. Test authority searching in the authority module in the staff client
    3. Test authority searching in the authority control plugin in the
       cataloguing module (and the plugin for UNIMARC field 210$c, if you
       can figure out how)
    4. Test authority searching in the OPAC
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Tested with MARC21 data.
    
    1) Applies cleanly on current HEAD.
    
    2) Authority search in staff
    
    Patch works wonderfully, only some small notes found while testing that have
    not been changed by this patch:
    
    ENH note: Search terms show up nowhere. So if I want to change the sorting, I have to
    repeat typing in my search term. Even if the form does not keep the term, it
    should be visible somewhere on the screen what I searched for.
    
    ENH note: The pagination on top and at the bottom of the result list are formatted
    differently. Maybe some missing CSS?
    
    ENH note: Also the authority type is not shown at all in the result list.
    
    3) Cataloguing and authority plugins
    
    The autocomplete function works nicely.
    
    ENH note: There is only one small enhancement
    I could imagine. If I start my search from 100 it will limit the search to
    'persons' but the autocomplete will also suggest other authorities. It would
    be a bit cleaner, if the autocomplete could limit by the appropriate authority
    type too. Very nice feature.
    
    Plugins overall work nicely. Created links include the authority numbers and work
    correctly.
    
    4) Authority search in OPAC
    
    Works nicely. Display is consistent, but translatability greatly improved.
    
    ENH note: In staff we use 'Details' in OPAC we use 'View full heading' - I wonder
    if maybe 'details' would be better understandable for users?
    
    Note: Code reveals a system preference 'AuthDisplayHierarchy' that is
    not available in the system preference editor. I talked to Jared and he
    will work on this feature later on. For now it's no regression, as the
    preference has never been visible.
    
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Rebased for 3.8.x on 21 June 2012.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    5 +-
 C4/AuthoritiesMarc.pm                              |  335 ++++++++++----------
 authorities/ysearch.pl                             |   10 +-
 cataloguing/addbiblio.pl                           |    1 -
 .../intranet-tmpl/prog/en/css/staff-global.css     |    9 +
 .../en/includes/authorities-search-results.inc     |   59 ++++
 .../modules/authorities/searchresultlist-auth.tt   |    3 +-
 .../en/modules/authorities/searchresultlist.tt     |    3 +-
 .../value_builder/unimarc_field_210c.tt            |    3 +-
 koha-tmpl/opac-tmpl/prog/en/css/opac.css           |    9 +
 .../en/includes/authorities-search-results.inc     |   59 ++++
 ...uthoritiesdetail.tt => opac-auth-MARCdetail.tt} |    6 +-
 .../en/modules/opac-authoritiessearchresultlist.tt |    8 +-
 opac/opac-authoritiesdetail.pl                     |   31 +--
 14 files changed, 341 insertions(+), 200 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
 create mode 100644 koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc
 rename koha-tmpl/opac-tmpl/prog/en/modules/{opac-authoritiesdetail.tt => opac-auth-MARCdetail.tt} (92%)


hooks/post-receive
-- 
main Koha release repository