[koha-commits] main Koha release repository branch new/bug_4246 created. v3.08.00-260-g591bae3

Sun Jun 10 18:17:15 CEST 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_4246 has been created
        at  591bae324d77d285b27dfa6e10dc7001671f53cc (commit)

- Log -----------------------------------------------------------------
commit 591bae324d77d285b27dfa6e10dc7001671f53cc
Author: Paul Poulain <paul.poulain at biblibre.com>
Date:   Sun Jun 10 18:16:33 2012 +0200

    Bug 4246 Follow-up updatedatabase

commit 1d53bd778be4fd8ceddb0e918d142ddb67317ac7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Sat Jun 9 16:21:02 2012 -0400

    Talking Tech Support - Phase I - Followup 3 - Follow PBP

    * Fixes violations of Perl Best Practices, where possible
    * perltidy both scripts

    http://bugs.koha-community.org/show_bug.cgi?id=4246
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

commit 9e745aff029ba84e8e622692d9448b769160d8ce
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu May 10 12:01:11 2012 -0400

    Talking Tech Support - Phase I - Followup 2 - Bugfix

    http://bugs.koha-community.org/show_bug.cgi?id=4246
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

commit 47e4f3ed84c819f61c4325c94316372cb27fa437
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Mar 26 11:43:02 2012 -0400

    Talking Tech Support - Phase I - Followup - Fix Messaging Preferences

    There is a flaw in C4::Members::Messaging::GetMessagingPreferences where
    the system assumes that every transport will use the same letter. This
    is not necessarily true. Even with the default preferences of just
    'email' and 'sms', we should be able to have different letters
    for each, as one has a maximum character length ( sms ) and one
    does not. GetMessagingPreferences currently uses the letter code
    of the last result of its query as the letter code for every transport type.

    The returned data is a hashref with a key 'transport_types' that is
    an array of transport_types this borrower has selected for the given
    alert.

    This commit modifies GetMessagingPreferences such that the the
    'transport_types' array is now a hash where the name of the transport
    type is now a key to the value of the letter code set for that transport
    type.

    It also modifies code calling GetMessagingPreferences where necessary,
    and as a side benefit will correctly get the letter codes for email
    and sms correctly, if they are defined differently.

    http://bugs.koha-community.org/show_bug.cgi?id=4246
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

    In use in production by two libraries: Middletown and Washoe
    who give their sign off but don't have git to do so.

    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

commit d29efac4f3792df8eb9325cf8a350346972bdbb7
Author: Ian Walls <ian.walls at bywatersolutions.com>
Date:   Wed Feb 22 12:44:38 2012 -0500

    Talking Tech Support - Phase I

    Implements support for Talking Tech I-tiva phone notification for OVERDUE, PREDUE and HOLD notifications.
    Overdues respect triggers as configured for the patron's branch.
    Predue and Holds notifications respect patron's messaging preference choices.
    A new column for phone notification is added if the TalkingTechItivaPhoneNotification system preference is turned on

    Record of phone messages being sent to patrons is added to the patron's Notices
    tab; notice of success or failure can be retrieved from I-tiva.

    See the TalkingTech.README for installation and set-up instructions.

    Aside from the control system preference, and the necessary changes to Messaging Preferences
    forms to make use of phone notifications, the bulk of the code resides in external
    cronjobs.

    TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva.  Actual transmission
    of the file must be handled by the system administrator.

    TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva.  Getting the
    file from I-tiva to Koha is the job of the system administrator, as well.

    Both scripts have a --help option with full documentation.

    The only necessary change to core Koha behavior is in C4::Letters::EnqueueLetter.  The return
    value was changed from 0 or 1 (successful addition of letter to message_queue or not), to the actual
    insert ID of the letter.  This was required by the outbound script to present a unique Transaction ID
    for the notice added to the patron's record (so a 'sent' or 'failed' status could be updated).  Since
    the dbh and sth are not shared, and the last_insert_id() command is table-specific, this should be thread-safe.
    No changes are necessary to any parts of Koha, as all usage of EnqueueLetter currently ignores the return value.

    To Test:

    1. Turn on TalkingTechItivaPhoneNotification system preference
    2. Verify that 'phone' is now a valid notification option for patrons on both staff and OPAC side
    3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt should succeed
    4. Set up the patron for notices to triggers:
       a. include checked out items due in a range of days, including the value set up in their messaging preferences.
       b. place several holds, some in position, others waiting for pickup, others in transit.
       c. set the patron up to have overdues, overdue by a range of days that includes the delay values for
    the patrons branch and categorycode
    5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE --type=OVERDUE --outfile=/tmp/talkingtechtest.csv

    The resulting talkingtechtest.csv file should include all the items due on X days (where X is the patrons' preference),
    and none of the ones due in other increments.  Similarly, overdues messages should be added for each item due by a delay
    value as configured; overdues of other numbers of days should be ignore.  Holds that are waiting pick up or in transit should
    have messages, those still pending should not.

    Messages should be added to the patron's notices tab for each issue sent.  Verify these messages exist, and all Notices
    tokens are replaced with appropriate information.

    Repeat, this time with 4c making use of the default branch overdue triggers, instead of branch-specific triggers.

    To test the inbound script, create a CSV with rows in the format "<<Message_id>>","<<SUCCESS or FAIL>>"
    Message ID should correspond to the final column of the talkingtechtest.csv file (the transaction id) for the message.

    Primary Authorship: Ian Walls
    Additional modifications: Kyle M Hall

    http://bugs.koha-community.org/show_bug.cgi?id=4246
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

    Tested and in use in production by two public libraries : Middletown
    and Washoe. Both have given their sign off, but don't have git to
    actually sign off.

    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------

hooks/post-receive
-- 
main Koha release repository