[koha-commits] main Koha release repository branch new/bug_7961 created. v3.08.00-284-g622967b

Git repo owner gitmaster at git.koha-community.org
Wed Jun 20 09:42:57 CEST 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_7961 has been created
        at  622967b323901a3bf86b892439f728ea8f852f9e (commit)

- Log -----------------------------------------------------------------
commit 622967b323901a3bf86b892439f728ea8f852f9e
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date:   Sat Apr 14 11:39:20 2012 +0200

    Bug 7961 - Local cover images should support CSV link files
    
    Corrent code doesn't have support for filenames which contain spaces
    or commans which breaks CSV files saved from spreadsheet similar to:
    
      12345, "conver image, with spaces.jpg"
    
    This patch tweaks file parsing a bit. We are always splitting line to
    only two values (to support commas as part of filename) and removing
    spaces only on beginning and end of filename (to cover space after
    comma in CSV example above while preserving spaces in filename).
    
    With this change only invalid character in picture filename left
    are quotes (") which are commonly used to quote strings with spaces.
    
    Covers added will be logged in action_log, using CATALOGUING / MODIFY
    action (which is shown as "Catalog" in tools > Log viewer)
    
    Test scenario:
    
    1. collect pictures with spaces and commas in name
    2. dump file list into CSV file and add biblio number as first column
       (name of file is idlink.txt or datalink.txt)
    3. create zip with CSV file and pictures
    4. verify that all pictures got uploaded and linked to biblio records
    5. verify that modification log includes cover image name
    
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list