[koha-commits] main Koha release repository branch 3.6.x-maint/testing created. v3.06.04-110-g4b0cbab
Git repo owner
gitmaster at git.koha-community.org
Mon May 7 17:48:45 CEST 2012
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.6.x-maint/testing has been created
at 4b0cbab8c286c5d6b168826334c177b1d7116ac5 (commit)
- Log -----------------------------------------------------------------
commit 4b0cbab8c286c5d6b168826334c177b1d7116ac5
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Wed Oct 26 16:02:32 2011 +1300
Bug 8020 [3.8.x/MASTER] - update changelogs to get to 3.8
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 1ccc299f583a5dc175ce6885ce7022131105969c
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Fri Apr 20 16:59:35 2012 +0200
Bug 3969 follow-up = budget name field is budget_name, not name
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 6dd7628d5f36f7f33d9b143f78cbbffa3b58ab3c
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sat Apr 14 19:39:30 2012 +0200
Bug 3969: Budget search in acquisition does't work (search)
Search term was never evaluated.
Patch makes sure input param is correctly stored in the variable
and changes comparison to be case insensitive.
To test:
- Check search for fund codes (case insensitive) works
- Check search for fund code in combination with library works
The budgets to be shown can depend on your permissions.
Testing with with a superlibrarian should bring up all funds.
Also fixes warns in the logs that appeared when viewing the funds
for a budget without funds.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Funds are now searchable.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 29488904daae8412cbbc31610d41adb3e291dd11
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Fri Apr 20 09:52:04 2012 +1200
Bug 6931 : Only update frameworks for the correct marcflavour
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 0bd64383d04983b718fa0e00c874c7b0eb1bed9f
Author: MJ Ray <mjr at phonecoop.coop>
Date: Wed Apr 18 16:34:02 2012 +0100
Bug 1577 - update INSTALL to mention need to translate templates
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 53efa78b928fef1cf21e06eb45bf3a308b906593
Author: MJ Ray <mjr at phonecoop.coop>
Date: Thu Apr 5 13:18:07 2012 +0100
Bug 6267 custom http user-agent in check-url.pl (fix for books.google.com 401 error)
Patch by Judit with a small change to the help wording.
Sponsored by CALYX information essentials.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 12b2a3b70f7ea9cd157ae33b66156212f15c06d1
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Tue Mar 27 09:56:33 2012 +0200
Bug 7726: explanation and options that were in the wrong order
I also removed the ` mysql-ism
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 86e9ef050ec6673004951a95b3b4a693943f10e0
Author: Gaetan Boisson <gaetan.boisson at biblibre.com>
Date: Thu Apr 12 17:59:32 2012 +0200
Bug 7693 - clear screen button misaligned
This patch removes firefox specific lines in the css which were breaking the display
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
This fixes the layout problem in current versions of Firefox. I think
the CSS which is removed by this patch might be necessary for older
versions of Firefox, but if this turns out to be a problem we can
follow up.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b31fc42f0744573c1571b8b3bb6441d4a15c3c84
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 12 12:25:09 2012 -0400
Bug 7950 - Typo for preference intranetuserjs
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 10d351b9be05702acb4a1efb29cccb70f811524a
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Apr 15 00:09:34 2012 +0200
Bug 3337 - RSS link is not correct for searches without results
RSS links for searches without results didn't have the search terms.
To test:
- Search for something with results and check RSS link
- Search for something with no results and check RSS link
In both cases your search should show up in the link.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
RSS Link works in both cases listed in test plan.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 76a725c85da7478a6f751067bc1e6785ff75a78c
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sat Apr 14 17:50:51 2012 +0200
Bug 7833 - unique holiday link broken
As Nicole stated on the bug the branchcode was missing from the links.
To test:
- add unique holidays to calendar for different branches
- click on link and check that the date is opened in the right calendar
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Clicked links for unique holidays and exceptions for
multiple branches and everything works perfectly.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit e2ed1e7ffc246310beffdcc12e9a6d7c46953abc
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Apr 9 17:44:38 2012 +0200
Bug 7845: Multiple 260s don't display properly in search results
Corrects display for multiple 260 fields in intranet and OPAC.
In intranet the order of fields was wrong on the detail page.
In OPAC and intranet punctuation for multiple 260 fields in the
result list was not displaying properly.
Example after correction:
Publisher: Jena : Elsevier, 1907 ; Stuttgart : Franckh, 1907-1992 ; Jena : Urban & Fischer, 1993-2003
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit aed21cfde160f76dfc2e4ae1d29f18d94e61c7bd
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Apr 8 13:30:10 2012 +0200
Bug 7922: Fixing typo in German sample news
Fehlerkorrektoren > Fehlerkorrekturen
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 2ae75d65d352614243f024cd4aee77c64a3fef56
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Apr 12 08:59:32 2012 +0200
Bug 7354: Can't edit local use system preferences
Fixes adding and editing of local use system preferences and redirects to correct
page after saving.
To test:
- Create a new local use system preference
- Edit an existing local use system preference from summary page
- Edit an existing local use system preference using 'Edit'
- Delete a local use system preference
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit ed2420273bd29b5a4e69ff8b54826bff8d3b595a
Author: mveron <veron at veron.ch>
Date: Sun Apr 15 17:20:16 2012 +0200
Bug 7528 - amount subtracting 1 cent
Rounding issue with JavaScript and float numbers, JavaScript changed to do no calculation if discount is 0
Signed-off-by: Ian Walls <koha.sekjal at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit da4abc7a334d0953389cf0ee17d4afb7fc03a074
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Wed Apr 11 08:41:57 2012 +0200
Bug 7927 - library not showing on subscription full history anymore
Restores former functionality:
Shows the branchcode in the branch column for the full history
view of subscriptions in OPAC.
http://bugs.koha-community.org/show_bug.cgi?id=7929
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Branch codes are visible again.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit c85c7ca150bf8ab958d2adcf7dd376d410b3db73
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Apr 11 16:13:22 2012 -0400
bug 7016 further followup: clarify return of GetItemnumbersForBiblio
New function was actually returning an arrayref, so made
perldoc and function usage consistent.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit bc79b5d000479e728838c3b03b351dd6ed43c390
Author: Ian Walls <ian.walls at bywatersolutions.com>
Date: Fri Jan 6 09:53:49 2012 -0500
Bug 7016 Followup: Add new GetItemnumberForBiblio subroutine
Adds a new subroutine in C4::Items, GetItemnumbersForBiblio, which takes a
single biblionumber, and returns an array of all the corresponding itemnumbers.
This patch also replaces the usage of get_itemnumbers_of in C4::Reserves::CanBookBeReserved
with this new subroutine, as the output is more consistent with what we were
lookng for (this is what fixes the bug issue).
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 8334e1a18e0fc0f39fec5aa65d85560cdf4952e2
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Tue Mar 27 16:04:12 2012 +0100
Bug 7831 : Sort budgets for selection in new order
The select budget dropdown list should be presented in
an ordered fashion. To achieve this sort the budget array
by the visible text.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 0a476f82315e23b0853e38a3b8894cfba1914915
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Apr 10 11:36:36 2012 -0400
Bug 7940 - Placing a hold on a single item from the staff cart causes errors
This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.
When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.
In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).
There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )
This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
passes tests, works as advertised. Good catch!
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 809af2ba094a9cd192b411775560e17ad50b3c39
Author: Serhij Dubyk {Сергій Дубик} <serhijdubyk at gmail.com>
Date: Wed Mar 28 02:46:09 2012 +0300
Bug 7838 - Add sort-string-utf.chr for Ukrainian and Russian
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 306b0e6c2de741db2d099e2860f38d69b60507c1
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Tue Apr 10 16:13:37 2012 +0200
Updating euskara and french translation teams
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 40bfc987e1623cf9b2a62d9cb0585021db31a6bf
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu May 3 20:09:18 2012 -0400
Bug 7935 follow-up: Update DBRev
Version 3.06.04.004
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 6805abf40c4e76036105f88a7f426674c62b62a0
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Apr 9 21:27:16 2012 +0200
Bug 7935: Introduce sys pref to control 'browse results' in OPAC
Patch introduces a new system preference "OpacBrowseResults" to control
the feature for browsing and paging through results shown on top of the
left menu on detail pages in OPAC.
Preference is activated by default and can be deactivated using the
system preference.
To test:
- Check database update works correctly
- Check that browsing and paging still works with after database update
- Deactivate the feature by setting 'OpacBrowseResults' to 'Disable'
- Check the feature does no longer show up in OPAC
- Check that a new installation also has the system preference with correct default
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 6a0326d513e70d48236e32e6580c6d8c412e9c03
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Wed Apr 4 23:10:59 2012 +1200
Bug 7893 - add package dependencies
This adds some dependencies to the control file that are required.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b2eb0303c6cd859f8180fb7a553f6933890f4a4b
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Tue Mar 27 15:14:22 2012 +0200
Bug 6701 - login timeout is in seconds
I checked in C4/Auth and we are using perl time() for comparison with this value.
I also added description of specifying timeout in days which is available in code.
Robin Sheat suggested to document just lowercase d for days option, to reduce
confusion although uppercase D works as days specifier as well.
Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 30c3f0b5b58ff1e3bc5d188dd3d45ced6e73f07f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 5 11:16:47 2012 -0400
Bug 7758 - Koha allowing LOST items to check out without alert
Adds a confirmation alert when issuing an item that has
been marked as lost.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
passes tests, works as advertiesd
Tested:
- checking out an item that is marked lost performs all usual lost operations
- checking out an item that is marked lost prompts for confirmation
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 2319b752436d0f62b271572034ca24fd9464a7f0
Author: Magnus Enger <magnus at enger.priv.no>
Date: Mon Apr 2 15:27:49 2012 +0200
Bug 7445 - Clicking on a tag gives "Language ... does not exist"
To test:
- Syspref QueryStemming = Try
- Install Norwegian bokmål:
cd misc/translator/
perl translate install nb-NO
- Go to Home › Administration › System Preferences > I18N/L10N
and enable "Norsk bokmål(nb-NO)" for opaclanguages as well as
setting opaclanguagesdisplay = Allow
- Make sure you have selected "Norsk bokmål" as the active language
in the OPAC
- Find a record that has a tag (which does not contain any digits)
- Click on the tag and see that you get the error in the title of
this bug
- Apply the patch
- Click on the tag again and the error should be gone
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Easy to test with a great test plan. Works nicely.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit fce107c2aabb1a83c3926810d64ac377bb8e9e31
Author: Zeno Tajoli <tajoli at cilea.it>
Date: Sat Mar 31 10:08:29 2012 +0200
Bug 7143: Italian translation teams
http://bugs.koha-community.org/show_bug.cgi?id=7143
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 88883b4e3e229ec3a50824e25d932688df3138a4
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Apr 1 18:20:05 2012 +0200
Bug 7482: overdues report downloads without names
This patch is an alternate patch for the bug. Instead of having
one column 'name' for a concatenated first and last name it
adds 2 separate columns to the exported csv file.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 561bc060a36f5009312ae90845318d2eb284c16a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Apr 2 13:57:36 2012 -0400
Bug 7876 - Add ids to divs and spans with ids in opac-user.tt
This commit adds an id to each div, and adds spans where
there are no appropriate divs to add. In addition, non-static text
such as the expiration date are wrapped in a special sub-span so
that data can be pulled and reused when customizing via jQuery.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 2ed2283aa2c58b6596600b5cbe7519313ae6d8e8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 2 08:55:06 2012 -0400
Bug 7858 - Missing packages from install_misc/ubuntu.packages
- Adding missing dependencies to install_misc/ubuntu.packages
- Removing items from CPAN instructions which are installed
as packages
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Seems to add all necessary packages.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b5c733a7561a9e8ba90137319407e9eb3acf3594
Author: Liz Rea <wizzyrea at gmail.com>
Date: Tue Apr 3 10:35:28 2012 -0500
Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"
Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers.
To test:
- With a staff user with borrowers permission, verify the change password button is shown for a normal patron.
- With a staff user without borrowers permission, verify the change password button does not appear.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 3b94524e4e68e79f7bce3c026ea69f84f16e51a5
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date: Mon Apr 2 10:43:58 2012 +0200
Bug 7866: z39.50 search list ordered by rank
In the z39.50 cataloging search page, the servers
are now sorted by rank and name.
Signed-off-by: Marijana Glavica <mglavica at ffzg.hr>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit a003b6fa96c878a0f1566bd3dc2aca7eec111dbb
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Apr 2 21:01:26 2012 +0200
Bug 1662: Is there a difference between Full and Simplified for Serials History
Changes description of system preference SubscriptionHistory:
When showing the subscription information for a bibliographic record,
preselect [brief history|full history] view of the serial issues.
To test:
1) Verify new description shows in system preference editor (tab serials)
2) Verify description is correct (OPAC > Subscription tab > more details)
Signed-off-by: Marijana Glavica <mglavica at ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 78dc87ef01137946b62076cc374a81e1a7087727
Author: Serhij Dubyk {Сергій Дубик} <serhijdubyk at gmail.com>
Date: Sat Mar 31 01:20:18 2012 +0300
Bug 6434 - Ukrainian and Russian MARC sql-tables
Changes: Marc21 support, 995 for items (Unimarc), authorities types for both
MARC's, many small field/subfield changes
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
It works, doesn't break anything, seems to be in Ukrainian/Russian (I can't
judge).
It's a huge patch (21M). That's why it's attached as a bz2 archive: so the
archive must be downloaded, decompressed, and then applied.
General remark: Adding this patch to Koha will increase substantially Koha git
repository size. It shows that non-code files (.po files, SQL files)
could/should be managed outside Koha core repository. See this discussion:
http://wiki.koha-community.org/wiki/Git_Splitting_and_Shrinking
Here is my test plan:
[1] Apply the patch on master
[2] Install ru-RU and uk-UA languages:
cd misc/translator
./translate ru-RU uk-UA
[3] re-create Koha DB:
DROP DATABASE koha;
CREATE DATABASE koha;
[4] Load Koha pro interface: get web installer
[5] Choose ru-RU language
[6] Everything is in Russian. Click blindly on button until reaching the
page where to choose Unimarc/Marc21.
[7] Choose Unimarc.
[8] Tick on everything to load all UNIMARC SQL files.
[9] All SQL are loaded without any error.
[10] Check Koha cataloguing.
[11] Go to [3] and choose Marc21 at step [7].
[12] Go to [3] and choose uk-UA at step [5].
[13] Go to [3] and choose uk-UA at step [5] and Marc21 at step [7].
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit ea334df3e6a4b88c196ea73e3708e38193b522a2
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Mar 11 13:48:43 2012 -0400
Bug 7617: Sort authority results by authid
Add the option of sorting authority search results by authid, and instruct the
FirstMatch and LastMatch linkers to use that sort order rather than the default
search order.
To test:
1. Install new Zebra authorities config
etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml,
etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl,
etc/zebradb/marc_defs/marc21/authorities/record.abs, and
etc/zebradb/marc_defs/unimarc/authorities/record.abs
2. Reindex authorities in Zebra
3. Set LinkerModule to FirstMatch or LastMatch
4. Add two identical authority records, and a bib record with a heading that
matches them
5. Run misc/link_bibs_to_authorities.pl on that record
6. Confirm that the authid that's been inserted into subfield $9 of that
heading is the first, if you selected FirstMatch, or last if you selected
LastMatch
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
I followed the test plan and checked that for "Last match" and "First match"
the correct authority was selected and linked to the record.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit cf618fb80c50b94cb25a494ebb4a112ea4c974fa
Author: Magnus Enger <magnus at enger.priv.no>
Date: Thu Feb 16 12:07:35 2012 +0100
Bug 7537 - Implement TraceCompleteSubfields, TraceSubjectSubdivisions and UseICU for NORMARC XSLT
IMPORTANT! This patch relies on the patch for Bug 7092, which is now pushed to
master.
As the title says, this patch implements TraceCompleteSubfields,
TraceSubjectSubdivisions and UseICU for NORMARC XSLT, both for the OPAC
and the Intranet. This affects how clickable subject-links are constructed.
To make this work the indexing of MARC fields in the 600 range is changed
to include "Subject:p" in several new places.
To test:
Find a record with a "complex" subject, like "Internet -- Law and legislation".
MARC21 and NORMARC are very similar in how they handle subjects, so testing
on a MARC21 database should be OK. (Changes in indexing reflect changes already
made to the MARC21 indexing.)
Make sure you have these syspref settings:
- marcflavour = NORMARC
- XSLTDetailsDisplay = using XSLT stylesheets
- OPACXSLTDetailsDisplay = using XSLT stylesheets
(Ideally, testing should be done on a real NORMARC setup, but since the changes
to indexing only reflect how it's already done in MARC21, I think testing
on a MARC21 installation with marcflavour = NORMARC should be OK.)
Now try the different combinations of TraceCompleteSubfields,
TraceSubjectSubdivisions and UseICU, and check the format of the
clickable links, both in the OPAC and staff client. Here's what you should
be seeing:
1.
TraceCompleteSubfields = Don't force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
opac-search.pl?q=su:"Internet"
UseICU = Using
opac-search.pl?q=su:{Internet}
2.
TraceCompleteSubfields = Force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
opac-search.pl?q=su,complete-subfield:"Internet"
UseICU = Using
opac-search.pl?q=su,complete-subfield:{Internet}
3.
TraceCompleteSubfields = Don't force
TraceSubjectSubdivisions = Include
UseICU = Not using
opac-search.pl?q=(su:"Internet") AND (su:"Law and legislation.")
UseICU = Using
opac-search.pl?q=(su:{Internet}) AND (su:{Law and legislation.})
4.
TraceCompleteSubfields = Force
TraceSubjectSubdivisions = Include
UseICU = Not using
opac-search.pl?q=(su,complete-subfield:"Internet") AND (su,complete-subfield:"Law and legislation.")
UseICU = Using
opac-search.pl?q=(su,complete-subfield:{Internet}) AND (su,complete-subfield:{Law and legislation.})
UPDATE 2012-03-23
- Change the syspref TracingQuotes to UseICU, see bug 7092
- Change boolean operator from "and" to "AND", see bug 7695
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Note: UseControlnumber must be turned off.
1) Works.
2) Works.
3) Works.
4) Works.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b09ea817545bba136a5122baf79fa7857c46ec41
Author: Magnus Enger <magnus at enger.priv.no>
Date: Mon Mar 26 22:05:45 2012 +0200
Bug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE
Set the rentalcharge = 0 for sample itemtypes (except Music for nb-NO).
To test:
Run through the web-installer for nb-NO and de-DE, and check that
itemtypes are displayed correctly for each language.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>.
Note: You have to install the language first in order to be able
to select it in the web installer. There was a problem
in the po files for nb-NO that kept all files from being created
correctly. I fixed the po file and did an installation with all sample
files. There is a problem with z3950servers.sql that is not caused
by this patch:
z3950servers.sql
ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1
Web installer for de-DE ran without problems on the sample files.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit dc217737273f7f9c33d3372b40fc05741385887b
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 16:34:28 2012 +0100
Bug 4819: Add ids to OPAC detail page
Patch adds an unique id to every item tab and
to every column in the items table on the holdings tab.
http://bugs.koha-community.org/show_bug.cgi?id=4819
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 840ef25a9b88a6a60225df96b40db4a600c43de4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Mar 27 12:01:33 2012 -0400
Bug 7485 - Cannot edit barcode on Fast Add
Simple fix, a special case was added for the fast add framework
in the case that an item was being checked out that had not been
catalogued. In that case, the barcode was being passed as a parameter
through addbiblio.pl to additem.pl.
This barcode param was used to overwrite the existing value, so if
no barcode param was passed ( which is only the case with fast adds
from the circ screen ), the barcode field would appear empty in the
items editor.
This commit causes that special case code to check for an existing
barcode value first, and only use the cgi parameter 'branch' in the
case that there is no existing barcode value.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Editing barcode of fast added item now works. Passes t xt
Recommend this for 3.6 release.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit f9ac69f610a45589692f8dac5dbf7e275bddbea9
Author: Magnus Enger <magnus at enger.priv.no>
Date: Tue Mar 20 13:45:48 2012 +0100
Bug 7695 - Change boolean operator from "and" to "AND"
When XSLTDetailsDisplay/OPACXSLTDetailsDisplay = on and
TraceSubjectSubdivisions = Include, subject sudivisions are
combined with the boolean operator "and". Currently, this word is
translated along with other occurrences of the same word, resulting
in a false "no records found" for users of non-English templates.
This patch replaces "and" with "AND" which should have no effect on
searching (since Zebra is case-insensitive in this regard) but will
make the boolean operator stand out from other uses of "and" in
translations.
TraceSubjectSubdivisions is currently only implemented in MARC21,
so UNIMARC and NORMARC is not affected.
To test:
XSLTDetailsDisplay/OPACXSLTDetailsDisplay = using XSLT
TraceSubjectSubdivisions = Include
marcflavour = MARC21
Find a record with a clickable subject that includes one or more
subdivisions and check that the subdivisions are combined with
"AND", not "and". Check that you get the expected result when
clicking on the subject.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Easy to test and works as advertised.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit f1d92920e102d1a6d1a77613f3adeae01d0dff48
Author: Magnus Enger <magnus at enger.priv.no>
Date: Tue Mar 27 22:35:35 2012 +0200
Bug 7837 - nb-NO z3950servers.sql misses column names
Fix installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql so it
includes column names.
To test:
- Install the nb-NO language
- Run through the web installer, and make sure to select the optional
("Valgfritt") z3950servers.sql file
- Check there are no errors
- Check that the Z39.50 errors are displayed OK in
Home › Administration › Z39.50 Servers
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Web installer runs without any errors now and I checked that
the Z39.50 servers were imported correctly and can be edited.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 342c63a9a7126ccc46f056d7442763a53a8f3ed8
Author: Magnus Enger <magnus at enger.priv.no>
Date: Fri Mar 23 15:59:59 2012 +0100
Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs
With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT,
the detail view displays a double set of tabs for Normal/MARC/ISBD
views, one above the title and one below.
To test:
marcflavour = NORMARC
OPACXSLTDetailsDisplay = Using XSLT
Since the contents of the recaords do not matter here, the patch
can be tested on MARC records of any flavour.
- Check that double tabs are shown
- Apply the patch
- Check that only the set of tabs at the top is shown
Signed-off-by: Marijana Glavica <mglavica at ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 30cd9f6dc9d77dcd4f02a59e7b6e7257b99acde5
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Fri Mar 23 09:59:19 2012 +0100
Bug 7760: More ids and classes for the staff interface
Owen pointed out that I missed 3 files - this corrects my omission.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 55d536a45818e5efa060ab4cf9b4a06e0bad69eb
Author: Gaetan Boisson <gaetan.boisson at biblibre.com>
Date: Tue Mar 20 17:03:14 2012 +0100
Bug 7761 - cleaning up empty declarations from staff-global.css
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit ee2a238c1bcbab0a2b5ae5710933fb9d18619e05
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Mar 11 12:57:11 2012 -0400
Bug 7702: [SIGNED-OFF] MARC21 heading tests should not run under UNIMARC
Skip the MARC21-specific tests in t/Heading_MARC21.t if the marcflavour is
UNIMARC.
Signed-off-by: Magnus Enger <magnus at enger.priv.no>
I set marcflavour = UNIMARC for testing this.
Before the patch, t/Heading_MARC21.t fails. After the patch it
succeeds.
Signed-off-by: Magnus Enger <magnus at enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b33d171911c5061bbafc44ed3100412c74918f57
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Wed Mar 21 16:18:29 2012 +0100
Bug 7780: make silent/verbose flag for translation installing
This patch deal with the -v flag that you can put on translate script.
If you run without -v, the process should be silent
if you run with -v, the process should be verbose
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
I've refactored your patch to handle verbosity directly via a translator
attribute, rather than with parameter which has to be send to each object call
method.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b47a5806657e25ef6be181770fb8f2c53fae5353
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 12:09:59 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customization (reports, ...)
This is the last one - adding the classes and ids to the report module and
some template files for smaller moduls/functions.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 94ce90b415d2557adbd5d3808ea37f663b55acd8
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 11:53:48 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customization (patroncard, labels)
After talking to Owen we decided to use 2 classes for those modules. I decided on:
patroncard: tools, pcard
labels: tools, labels
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 0295bcd4a1f041302188b367e8a996ccbbd158bd
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 11:40:09 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customization (tools)
Prefix for ids and class is 'tools'
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 0047e470cf53fbf7aec07c8474c8c31436f052e6
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 11:19:45 2012 +0100
Bug 7760: Add ids and classes to every staff page to help with customization (serials)
http://bugs.koha-community.org/show_bug.cgi?id=7760
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit c1ce771a8b0fd0948778270c274ea81ab6e1beb1
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 11:12:12 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customization (patrons)
Class is 'pat' and ids start with 'pat_'.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 3424924256fdd90eb14901a218b407a1079ee6c3
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Mar 22 11:00:54 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customizaton (lists, suggestion, z39.50)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 164de02c8450e573dcd38792c08564e33249895d
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Wed Mar 21 22:45:09 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customizaton (circulation)
New id: circ_<filename>
New class: circ
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 9f667c91c8446aebdc864f605b1bcf30ce763abb
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Wed Mar 21 22:07:33 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customizaton (cataloguing)
New ids: cat_<filename>
New class: cat
Exceptions:
moveitem and linkitem are accessible from the catalog pages, so have
been made 'catalog' for styling.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit feced30657770f65c69e047c8c377981a314224b
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Wed Mar 21 16:54:47 2012 +0100
Bug 7760 - Add ids and classes to every staff page to help with customizaton (catalog)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 044089e1ecc0f95dde7aa429199962908f7e7261
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Wed Mar 21 16:25:10 2012 +0100
Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 357ba097aa30cbac4c3972e5c58d8610e157722d
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Wed Mar 21 16:19:00 2012 +0100
Bug 7760: Add ids and classes to every staff page to help with customizaton (cart)
id = cart_<filename>
class = cart
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit f508618e232eaba91a6152853236121716674f66
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Tue Mar 20 18:00:32 2012 +0100
Bug 7760: Add unique ids and a module class to all administration pages
This is the first patch for bug 7760 and touches all pages in administration.
This adds a unique id "admin_<filename>" and a class "admin" to the body tag of
each page in administration.
Note: aqcontract can only be accessed from the acquisition module, so I made it acq
instead of admin.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 88ba5b8e74dac4ec6ac20b40c1a72cd91cfb13e8
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Tue Mar 20 17:02:41 2012 +0100
Bug 7760: Add unique ids and a module class to all authorities pages
This is the first patch for bug 7760 and touches all pages in authorities.
This adds a unique id "auth_<filename>" and a class "auth" to the body tag of
each page in the authorities module.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 3c14c7b23f7e0a25ec43e1b4ae1f0fb8e6809a47
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Tue Mar 20 16:41:17 2012 +0100
Bug 7760: Add unique ids and a module class to all acquisitions pages
This is the first patch for bug 7760 and touches all pages in acquisitions.
This adds a unique id "acq_<filename>" and a class "acq" to the body tag of
each page in acquisitions.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 7c0494bd1a43b0912e4a8adf34dd5124ced2ae7e
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Fri Feb 24 08:50:16 2012 +0100
SIGNED-OFF Bug 7590 Cataloging authorities search result page is broken
This bug occurs on UNIMARC DB with authorities linked together with TS/TG
relations. To reproduce it:
- Add a new biblio record
- On 610 field, click on the tag editor button to search an authority
- In the Authority search window, enter a large search
- On the result page, for authorities having relations with other terms, in the
Get it! column, you get a mess of TS/TG relations and not more Choose link.
Signed-off-by: François Charbonnier <francois.charbonnier at biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit e061b1d75a08a227a3e75eeff73d752daba21758
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Tue Feb 21 07:19:54 2012 +0100
Bug 5841: Routing slip not displaying publication date
To test:
Compare output of the 2 different links for printing routing lists.
1) Links in the table of issues on the serial collection page
2) Link following the steps from editing and saving a routing list
Both previews should show the date now.
Signed-off-by: Kristina D.C. Hoeppner <kristina at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 4c93de3f5c27cf0e946cf4294af81428a3921a54
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date: Tue Mar 20 13:56:56 2012 +0100
Bug 6125: repairs dateaccessioned plugin
1/ It now works with neworderempty.pl
2/ The set_to_today function was moved from
additem.tt to dateaccessioned.pl (so it's
available to all pages using the plugin)
Signed-off-by: Julien Sicot <julien.sicot at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 16da12b352cd9c7e71c35b9407883b9ed5305a7d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Mar 21 15:01:49 2012 +0100
Bug 5482 [Follow up] Translation problem in guided reports - Item field names
Making some additional corrections.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit a75c6cd311ec776bd6446acaba69d5962f6b1ceb
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Tue Mar 20 15:39:46 2012 +0100
Bug 5482: Update colums.def file
Updates the borrowers and items table descriptions using the
descriptions from the interface and the MARC21 default framework.
Biblio and biblioitems still need some work.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 37af8dc07ff1c0364df8718fd2d35ba9898e1a20
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 20 12:10:52 2012 +0100
Bug 5482 - Translation problem in guided reports - Item field names
This very minor correction adds display of the column name even
if the field description exists in the columns .def file.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Changes the display to show description / table.column.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 637f932470bdfddb6c55373f59942800d9624cf1
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Mar 14 14:34:27 2012 +0100
Bug 5180: FIX autocomplete on overdues report
- Switch off the CircAutocompl syspref
- Set a (one or more) patron attr type searchable
- go on the overdues page
Firebug crash and a layout problem appears on the left.
Firebug error is "YAHOO.widget.DS_XHR is not a constructor"
retry with this patch.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit ec411da3dbd8334d10fd2989a26ec0b073d9363d
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Mar 19 16:05:55 2012 +0100
Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable
The Javascript toggling the link description was checking for the english
link text. This would not work for translated templates.
Tested: Apply patch, then translate update and translate install.
Text changes as appropriate (with manually inserted translation in .po file)
Signed-off-by: mveron <veron at veron.ch>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 956834b97894bd901aad248bbea1652d36b129b6
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Mar 19 17:06:23 2012 +0100
Bug 7746: "No Public Lists." not translatable.
I applied the patch and did a translate update / translate install.
No public lists is now surrounded by P-tags as expected.
Signed-off-by: mveron <veron at veron.ch>
Signed-off-by: Ian Walls <koha.sekjal at gmail.com>
QA Comment: fixed small typo ('pists' instead of 'lists')
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b9ad3b2490210139e05052ecd9891c903e34066d
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date: Tue Mar 20 14:42:21 2012 +0100
Bug 7753: serials-home displays library name instead of code
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 330aecda5dc2d6fb10059ef29c2b11d57201a685
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Mar 11 18:47:18 2012 +0100
Bug 7700: Cart's more details view shows identity numbers
We already remove $9 with Koha's authority number from output
of GetMarcSubjects and GetMarcAuthors.
Patch additionally removes $0 subfields with identity numbers.
Patch also effects detail pages with normal (non-XSLT) views.
Revised to always remove $0 subfields, they are not used in UNIMARC.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 21abada751dcd199eedb8b904f92457b623254d7
Author: Maxime Pelletier <maxime.pelletier at libeo.com>
Date: Wed Feb 22 12:00:28 2012 -0500
Bug 7581: Singlebranchmode was always 0 causing the branch to be null and the reservations in the OPAC not to work in singlebranchmode.
Signed-off-by: Kristina D.C. Hoeppner <kristina at catalyst.net.nz>
http://bugs.koha-community.org/show_bug.cgi?id=7581
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 4230d360d5c08844e5e38db2652fb7f0ee091379
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Mar 8 14:35:08 2012 -0500
Bug 7597 - Part 5 - Remove my from $branch, which was masking previous declaration
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit c28daf6bffe4c9e02ddf61a4999ec51a288f2067
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Mar 5 15:29:44 2012 -0500
Bug 7597 - Part 4 - Change C4::Acounts::WriteOff to WriteOffFee
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit ead3223e0615304aa87654d63d352d61145fb32a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 28 09:34:59 2012 -0500
Bug 7597 - Part 3 - fines not recording the right info in the stats table
This commit fixes writeoff_all to write off only the amount outstanding
for each fine being written off, rather than the original amount owed.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b4b8e9bb16806f34203be47fe7cac7da5e73eb80
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 28 09:17:04 2012 -0500
Bug 7597 - Part 2 - move sub writeoff to C4::Accounts
Currently, the subroutine writeoff lives in pay.pl, which
is a violation of the Koha coding guidelines, as it writes
to the database. This commit restructures and moves writeoff
to C4::Accounts::WriteOff(), and modifies pay.pl to use it.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5c9cd701dfd8f83e0880f12389c2170bdf65b5fa
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 28 08:47:43 2012 -0500
Bug 7597 - Part 1 - fines not recording the right info in the stats table
Koha was writing off the value of accountlines.amount rather
than the value of accountlines.ammountoutstanding.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 6df5d9e5cfbdf936e18712fd861c0f8c5042dbf3
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu May 3 19:10:56 2012 -0400
Bug 7092 follow-up: Update DBRev
Version 3.06.04.003.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 84a1bfdf35bac5eb146fc8f160c6b3d6386a5fe9
Author: Magnus Enger <magnus at enger.priv.no>
Date: Mon Mar 5 13:36:43 2012 +0100
Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly
This patch adds a syspref UseICU for toggling between using "" and {} for
quoting in subject tracings. With normal Zebra indexing, "" must be used. With
ICU Zebra indexing, {} must be used.
This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions.
To test:
- marcflavour = MARC21
- make sure you have a record with a "complex subject", like
"Internet -- Law and legislation"
Toggle UseICU, TraceCompleteSubfields, and TraceSubjectSubdivisions and check
that you get the expected results for the clickable links in the OPAC detail
view:
TraceCompleteSubfields = Don't force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
opac-search.pl?q=su:"Internet"
UseICU = Using
opac-search.pl?q=su:{Internet}
TraceCompleteSubfields = Force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
opac-search.pl?q=su,complete-subfield:"Internet"
UseICU = Using
opac-search.pl?q=su,complete-subfield:{Internet}
TraceCompleteSubfields = Don't force
TraceSubjectSubdivisions = Include
UsingICU = Not using
opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.")
UsingICU = Using
opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.})
TraceCompleteSubfields = Force
TraceSubjectSubdivisions = Include
UseICU = Not using
opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.")
UseICU = Using
opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.})
Check that clicking on the generated links gives the expected search results,
but with normal and ICU indexing. (I have actually not tested this with ICU, so
doing that before signing off is crucial.)
UPDATE 2012-03-16:
Changed the name of the syspref from TracingQuotes to UseICU after a suggestion
from Paul P., to make it more generally useful.
I have used "Using/Not using" instead of "Use/Don't use" in the description of
the syspref, to reflect the fact that this syspref will not change how Zebra
does its indexing - it's just a way of telling Koha how the indexing is
actually done.
I have also set UseICU = 1 in updatedatabase.pl, since that will preserve the
current behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new
installations will not have ICU activated.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5ea2b54d0281a2bb1824c7502a54d83daa3c2957
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Mar 19 14:38:30 2012 +0100
Bug 7734: NO_LIBRARY_SET should be translatable
To test:
- Make sure you are logged into Koha as 'root' user - not superlibrarian
- Before the patch the label will show 'NO_LIBRARY_SET', after applying
the patch it will be 'NO LIBRARY SET' without underscores.
- Verify correct description is shown after selecting a library.
Signed-off-by: mveron <veron at veron.ch>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5e635fb880b2ad2ba8814ed7f5d076ecd710d1a4
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Mar 19 18:10:10 2012 +0100
Bug 7749: Not all OKs on the start page are translatable
I don't really understand, why the " OK " would not get picked up by
the translation script, but removing the spaces made it work.
To test:
Verify that all OK buttons on the start page are translatable. The one
resisting translation was "Search catalog:"
Signed-off-by: mveron <veron at veron.ch>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5a0183c469fc380986c1a743fe43ae0481345506
Author: Janusz Kaczmarek <januszop at gmail.com>
Date: Tue Jan 25 18:10:00 2011 +0100
Bug 5657: Changes made to sub merge to eliminate errors occuring when updating bibio records in batch (after updating multiple authority records)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 3866b9160542532279cfae4a4b6da7bb88116a26
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Tue Mar 20 15:58:50 2012 +0100
welcome gaetan, you're 179th !
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 711afab1ccf23998eaeff3221dcc952fb3e81133
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Fri Mar 16 07:38:24 2012 -0400
Bug 7724: Skip Linker test if Zebra isn't set up
One of the tests in t/db_dependent/Linker_FirstMatch.t ony works if Zebra is
running and authorities have been indexed. This was causing Jenkins agitas.
The test should be skipped if Zebra isn't running or authorities have not been
indexed at the time the test is run.
Signed-off-by: Ian Walls <koha.sekjal at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit e739d9ea1c1a00565a5903c185cfdeb78644c8f0
Author: Srdjan Jankovic <srdjan at catalyst.net.nz>
Date: Fri Jan 27 16:59:27 2012 +1300
bug_7140: Added item description to complement icon to search result and biblio detail pages
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
This seems like a very big improvement, especially for people using screen
readers. I agree that the change to C4::Search is required.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 46a55fb4bbee0491aba4e5f51a711469a915d3c3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 9 16:34:47 2012 -0500
Bug 4976 - Status of item returned with process_koc.pl is empty in Intranet
Fix to ensure items returned through a processed koc file have
items.onloan and items.datelastseen set corrrectly.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Uploaded a file with checked in and checked out items. all info
shows properly.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit befe5aa5e02a352e14447df6e4eeea7ac555be5c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Mar 8 08:53:45 2012 -0500
Bug 7670 - make required fields red
Adding "required" style and "Required" note to additem fields,
consistent with the way required fields are displayed
on the add patron form.
This patch also corrects an error in the client-side validation
script which misidentified which fields were required. Leaving
a required field empty should result in an alert and the missing
field being highlighted in yellow.
To test, open the add item form on a record which uses
a framework in which one or more item fields are required.
Required fields should be labeled in red and appended with a
"Required" note.
Submit the form while some required fields are empty. You should
see a javascript alert. The empty mandatory fields should have
a yellow background.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Works - passes tests.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b68645d1de2794f8fa769f2384c099f6e60f0516
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Mar 6 14:08:04 2012 -0500
Bug 7656 - "undefined" pop-up message when putting hold on reference item
This is a single line fix. Initializing the msg var to an empty
string solves the problem.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 4edc3c740a7ae569f41c9a701a54834a95073dca
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Fri Mar 16 11:54:13 2012 +0100
welcome David Cook, you're 178th
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 36a45c6d84472c644274c868a1838ed46a2e7960
Author: David <dcook at prosentient.com.au>
Date: Tue Mar 13 10:17:32 2012 +1100
Bug 7618 Escape HTML special characters for SQL displayed above results in Report module
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit a0f0ad85acb4dc7860e864958918721190a5f9f0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Mar 12 12:33:07 2012 +0100
7368 Typo in cart_to_shelf
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 8b3b4b4cc77e6b77a7a79a80793dee3b3d8c4b22
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Mar 5 14:47:51 2012 -0500
Bug 7644 - Invalid markup in staff client language chooser
This patch removes invalid markup from the language chooser
in the intranet. It also copies the markup and style of
the staff client include to the OPAC so the two are
more consistent. I hope that will make future changes
and debugging a little easier.
I believe this patch also fixes Bug 7366, "Language chooser
display problems."
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Patch fixes bug 7366, but there is still a difference between staff
and OPAC.
Installed languages: en, en-NZ, de-DE, fr-FR
Activated langauges: en, en-NZ, fr-FR
OPC shows English, staff shows en-NZ as label for the list.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 51f9cdd1b2106d92d0baff38298f872179e26d04
Author: Stéphane Delaune <stephane.delaune at biblibre.com>
Date: Tue Mar 6 16:20:01 2012 +0100
Bug 5749 Fix borrower address display in intranet
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit fc6a6da31df374ba61b81e42941aaf1a7d27125a
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Mar 11 13:19:00 2012 -0400
Bug 7699: Restricted until datepicker broken
To test:
1. Edit a patron, and try to use the datepicker to set the date the patron is
restricted until.
2. Note that the datepicker does not come up.
3. Apply patch.
4. Repeat step 1.
5. Note that the datepicker does come up.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 7211424640b3e0814777394c3ce37ee719f64894
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Feb 26 22:25:41 2012 +0100
Bug 7609: Improving links to find analytics and volumes when using UseControlnumber (MARC21)
To test:
- switch on UseControlnumber
- add a serial record with 001
- ldr pos 19 = a or
- 008 (continuing resource), pos 21 = m
- add 2 analytics with with $w subfields containing the 001 of the serial
- one with ldr pos 7 = a
- one with ldr pos 7 = b
- add 1-2 monographical records linked to the serial
- 8xx $w subfield containing the 001 of the serial
- 490
The serial should show 2 links (in both OPAC and Intranet):
'Show volumes' should only bring up the monographical records.
'Show analytics' should only find the analytical records.
Without the patch both links would find all linked records, no difference
between both links.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 7ae639a3e3caa5bd5352ac5370c81f5bcd055e46
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Fri Dec 2 07:56:27 2011 +0100
Bug 3216: UNIMARC author facets
Add 700$b to UNIMARC author facets.
Other facets subfields could be added now. For example, other subjects
subfields.
Following patches are required to handle better MARC21 subfields and choose
other subfields to deal with UNIMARC format.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Tested under both MARC21 and UNIMARC. Does not cause any regressions with
MARC21, and offers the possibility for better faceting there in the future.
Works as advertised with UNIMARC.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit a981c2aaf95f9c82fdffcf46eb5b2b07d59c2e53
Author: Liz Rea <wizzyrea at gmail.com>
Date: Wed Mar 7 13:29:58 2012 -0600
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images
Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results.
To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*):
* replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image.
* apply patch
* search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Ian Walls <koha.sekjal at gmail.com>
QA Comment: normalized spacing
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 6095d3cb830698f096a1939b9efc895d3a5c0182
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Mar 1 15:06:25 2012 -0500
Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow
This patch hides the "send cart" link if the opacuserlogin
preference is set to disallow. Other similar changes included:
- hide the "send list" link
- hide the "your lists" tab
- hide the "log in to create your own lists" link
- hide the "recent comments" link
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Tested with opacuserlogin set to both "Allow" and "Don't allow." With
opacuserlogin set to "Allow," the links showed up, and with opacuserlogin
set to "Don't allow," the links did not.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 96b41d4fbf71ceed691e581f2740917d7170d649
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Mar 5 12:38:00 2012 -0500
Bug 7645 - System preferences editor save button obscured by language chooser
This patch amends the preferences page's CSS file to add
bottom padding to the page container. This gives the bottom-
most submit button some breathing room.
Markup correction: Adding "row" and "col" attributes to
<textareas> to quiet validation errors. This doesn't
affect output at all (dimensions are specified in CSS).
To test, open the system preferences page to a tab like OPAC
which contains many preferences. At the bottom of the page
the last submit button should have about a line's worth of
white space below it.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit a3420ee2c8ed6a5ef25917f55ebf91b7f86b5e81
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Mar 1 10:00:14 2012 -0500
Bug 7631 - Self checkout renewal fails because of reference to non-existent subroutine in sco-main.pl
Changing "CanBookBeIssuedCheckout" to "CanBookBeIssued"
To test, try to renew an item which has no renewals left. Before the patch
you'll get an error:
Undefined subroutine &main::CanBookBeIssuedCheckout called at /opac/sco/sco-main.pl line 135.
After the patch you'll get the correct message about having no renewals left.
Other tests: checking out a barcode which doesn't exist, checking out an
item which is on hold for another patron.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5d715c9e354b35aefa5275764f73b5e5437f73ba
Author: Srdjan Jankovic <srdjan at catalyst.net.nz>
Date: Wed Mar 7 16:53:09 2012 +1300
Bug 6488: Display OPAC search result count conditional to OpacHiddenItems syspref
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Works as advertised. Amended this patch for a small spelling issue: supress->suppress. Could not suppress it ;)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 98af87330f67a179c6b29889008b493f3e5f0179
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Mar 1 09:40:01 2012 -0500
Bug 7629 - Update sco.css to include CSS Gradients and prevent error upon missing background image file
Copying CSS gradients for input buttons and dialogs from opac.css. Also copied missing
CSS for language-picker footer. Markup corrected in a couple of places in order
for the right style to be applied.
To test corrections to dialog CSS, enter an invalid patron barcode.
Multiple languages will have to be enabled in order to see the footer
correction working.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Dialog CSS looks correct, footer also looks correct with multi languages.
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 818c27f785ac6663961fcf0f21cec53827103364
Author: Liz Rea <wizzyrea at gmail.com>
Date: Mon Nov 28 11:39:33 2011 -0600
Bug 7271 - change sort in items.pm to sort by home library instead of holding branch
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit aef3967c2c74d0828f85c2e470f8f18cd6a63816
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu May 3 18:37:52 2012 -0400
Bug 7493 follow-up: Update DBRev
Version 3.06.04.002.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5eaca861a6c5922c29ca29de4acf008b4c647d0b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 6 09:05:18 2012 -0500
Bug 7493 [REVISED] Deleting a record with comments breaks "Recent Comments"
Adding foreign key constraint on biblio and borrowers:
- delete reviews when bibliographic records are deleted
- set set reviews.borrowernumber to NULL when patron records are deleted.
Before these constraints are set the database update script will
clean up existing instances of these problems by deleting reviews of
deleted biblios and setting to NULL reviews.borrowernumber for deleted
patrons.
In comments moderation, the list of comments will indicate "(deleted patron")
if the review was submitted by a patron who has since been deleted.
In the OPAC display of comments will omit the patron name altogether
if the patron has since been deleted.
To test:
1. CONFIRM THAT THE DATABASE UPDATE RUNS CORRECTLY
Before applying the patch:
- delete the record for a title which has a review
- delete a patron who has submitted a review (on a different title).
Viewing /cgi-bin/koha/opac-showreviews.pl should result in an error.
Apply the patch and make sure the database update runs. Viewing
the recent comments page in the OPAC should no longer result in an
error. The title with the comment from a deleted patron should
show no patron name on these pages:
- Recent comments (opac-showreviews.pl)
- Recent comments RSS (opac-showreviews.pl?format=rss)
- Detail page (opac-detail.pl)
Comments from other patrons should show correctly.
2. CONFIRM THAT NEW DELETIONS PERFORM CORRECTLY
After applying the patch:
- delete the record for a title which has a review
- delete a patron who has submitted a review (on a different title).
Viewing /cgi-bin/koha/opac-showreviews.pl should NOT result in an error.
The review of the title which you deleted should no longer appear in the
list of recent comments.
The title with the comment from a deleted patron should
show no patron name on these pages:
- Recent comments (opac-showreviews.pl)
- Recent comments RSS (opac-showreviews.pl?format=rss)
- Detail page (opac-detail.pl)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit de32bc8e7dcd11ed0a99b576dc96673e2494c33e
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu May 3 18:36:55 2012 -0400
Bug 7284 follow-up: Update DBRev
Version 3.06.04.001.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 53ef224eb2d0bafc5bd464122c6a5ffd8e5ffe91
Author: MJ Ray <mjr at phonecoop.coop>
Date: Thu Mar 29 18:35:04 2012 +0100
bug 7284: fix package build problem, move BEGIN into new
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit c25ab911c0b13fd8372a6a93afbc7478b816df76
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sat Dec 31 12:17:41 2011 -0500
Bug 7284: Authority matching improvements
Squashed patch incorporating all previous patches (there is no functional
change compared to the previous version of this patch, this patch merely
squashes the original patch and follow-up, and rebases on latest master).
=== TL;DR VERSION ===
*** Installation ***
1. Run installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt1
and installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt2
2. Make sure you copy the following files from kohaclone to koha-dev:
etc/zeradb/authorities/etc/bib1.att,
etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml,
etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl,
etc/zebradb/marc_defs/marc21/authorities/koha-indexdefs-to-zebra.xsl, and
etc/zebradb/marc_defs/unimarc/authorities/record.abs
3. Run misc/migration_tools/rebuild_zebra.pl -a -r
*** New sysprefs ***
* AutoCreateAuthorities
* CatalogModuleRelink
* LinkerModule
* LinkerOptions
* LinkerRelink
* LinkerKeepStale
*** Important notes ***
You must have rebuild_zebra processing the zebraqueue for bibs when testing this
patch.
=== DESCRIPTION ===
*** Cataloging module ***
* Added an additional box to the authority finder plugin for "Heading match,"
which consults not just the main entry but also See-from and See-also-from
headings.
* With this patch, the automatic authority linking will actually work properly
in the cataloging module. As Owen pointed out while testing the patch,
though, longtime users of Koha will not be expecting that. In keeping with
the principles of least surprise and maximum configurability, a new syspref,
CatalogModuleRelink makes it possible to disable authority relinking in the
cataloging module only (i.e. leaving it enabled for future runs of
link_bibs_to_authorities.pl). Note that though the default behavior matches
the current behavior of Koha, it does not match the intended behavior.
Libraries that want the intended behavior rather than the current behavior
will need to adjust the CatalogModuleRelink syspref.
*** misc/link_bibs_to_authorities.pl ***
Added the following options to the misc/link_bibs_to_authorities.pl script:
--auth-limit Only process those headings that match the authorities
matching the user-specified WHERE clause.
--bib-limit Only process those bib records that match the
user-specified WHERE clause.
--commit Commit the results to the database after every N records
are processed.
--link-report Display a report of all the headings that were processed.
Converted misc/link_bibs_to_authorities.pl to use POD.
Added a detailed report of headings that linked, did not link, and linked
in a "fuzzy" fashion (the exact semantics of fuzzy are up to the individual
linker modules) during the run.
*** C4::Linker ***
Implemented new C4::Linker functionality to make it possible to easily add
custom authority linker algorithms. Currently available linker options are:
* Default: retains the current behavior of only creating links when there is
an exact match to one and only one authority record; if the 'broader_headings'
option is enabled, it will try to link to headings to authority records for
broader headings by removing subfields from the end of the heading (NOTE:
test the results before enabling broader_headings in a production system
because its usefulness is very much dependent on individual sites' authority
files)
* First Match: based on Default, creates a link to the *first* authority
record that matches a given heading, even if there is more than one
authority record that matches
* Last Match: based on Default, creates a link to the *last* authority
record that matches a given heading, even if there is more than one record
that matches
The API for linker modules is very simple. All modules should implement the
following two functions:
<get_link ($field)> - return the authid for the authority that should be
linked to the provided MARC::Field object, and a boolean to indicate whether
the match is "fuzzy" (the semantics of "fuzzy" are up to the individual plugin).
In order to handle authority limits, get_link should always end with:
return $self->SUPER::_handle_auth_limit($authid), $fuzzy;
<flip_heading ($field)> - return a MARC::Field object with the heading flipped
to the preferred form. At present this routine is not used, and can be a stub.
Made the linking functionality use the SearchAuthorities in C4::AuthoritiesMarc
rather than SimpleSearch in C4::Search. Once C4::Search has been refactored,
SearchAuthorities should be rewritten to simply call into C4::Search. However,
at this time C4::Search cannot handle authority searching. Also fixed numerous
performance issues in SearchAuthorities and the Linker script:
* Correctly destroy ZOOM recordsets in SearchAuthorities when finished. If left
undestroyed, efficiency appears to approach O(log n^n)
* Add an optional $skipmetadata flag to SearchAuthorities that can be used to
avoid additional calls into Zebra when all that is wanted are authority
records and not statistics about their use
*** New sysprefs ***
* AutoCreateAuthorities - When this and BiblioAddsAuthorities are both turned
on, automatically create authority records for headings that don't have
any authority link when cataloging. When BiblioAddsAuthorities is on and
AutoCreateAuthorities is turned off, do not automatically generate authority
records, but allow the user to enter headings that don't match an existing
authority. When BiblioAddsAuthorities is off, this has no effect.
* CatalogModuleRelink - when turned on, the automatic linker will relink
headings when a record is saved in the cataloging module when LinkerRelink
is turned on, even if the headings were manually linked to a different
authority by the cataloger. When turned off (the default), the automatic
linker will not relink any headings that have already been linked when a
record is saved.
* LinkerModule - Chooses which linker module to use for matching headings
(current options are as described above in the section on linker options:
"Default," "FirstMatch," and "LastMatch")
* LinkerOptions - A pipe-separated list of options to set for the authority
linker (at the moment, the only option available is "broader_headings," which
is described below)
* LinkerRelink - When turned on, the linker will confirm the links for headings
that have previously been linked to an authority record when it runs. When
turned off, any heading with an existing link will be ignored.
* LinkerKeepStale - When turned on, the linker will never *delete* a link to an
authority record, though, depending on the value of LinkerRelink, it may
change the link.
*** Other changes ***
* Cleaned up authorities code by removing unused functions and adding
unimplemented functions and added some unit tests.
* This patch also modifies the authority indexing to remove trailing punctuation
from Match indexes.
* Replace the old BiblioAddAuthorities subroutines with calls into the new
C4::Linker routines.
* Add a simple implementation for C4::Heading::UNIMARC. (With thanks to F.
Demians, 2011.01.09) Correct C4::Heading::UNIMARC class loading. Create
biblio tag to authority types data structure at initialization rather than
querying DB.
* Ran perltidy on all changed code.
*** Linker Options ***
Enter "broader_headings" in LinkerOptions. With this option, the linker will
try to match the following heading as follows:
=600 10$aCamins-Esakov, Jared$xCoin collections$vCatalogs$vEarly works to
1800.
First: Camins-Esakov, Jared--Coin collections--Catalogs--Early works to 1800
Next: Camins-Esakov, Jared--Coin collections--Catalogs
Next: Camins-Esakov, Jared--Coin collections
Next: Camins-Esakov, Jared (matches! if a previous attempt had matched, it
would not have tried this)
This is probably relevant only to MARC21 and LCSH, but could potentially be of
great use to libraries that make heavy use of floating subdivisions.
=== TESTING PLAN ===
Note: all of these tests require that you have some authority records,
preferably for headings that actually appear in your bibliographic data. At
least one authority record must contain a "see from" reference (remember which
one contains this, as you'll need it for some of the tests). The number shown
in the "Used in" column in the authority module is populated using Zebra
searches of the bibliographic database, so you *must* have
rebuild_zebra.pl -b -z [-x] running in cron, or manually run it after running
the linker.
*** Testing the Heading match in the cataloging plugin ***
1. Create a new record, and open the cataloging plugin for an
authority-controlled field.
2. Search for an authority by entering the "see from" term in the Heading Match
box
3. Confirm that the appropriate heading shows up
4. Search for an authority by entering the preferred heading into the Main
entry or Main entry ($a only) box (i.e., repeat the procedure you usually
use for cataloging, whatever that may be)
5. Confirm that the appropriate heading shows up
*** Testing the cataloging interface ***
6. Turn off BiblioAddsAuthorities
7. Confirm that you cannot enter text directly in an authority-controlled field
8. Confirm that if you search for a heading using the authority control plugin
the heading is inserted (note, however, that this patch does not AND IS NOT
INTENDED TO fix the bugs in the authority plugin with duplicate subfields;
those are wholly out of scope- this check is for regressions)
9. Turn on BiblioAddsAuthorities and AutoCreateAuthorities
10. Confirm that you can enter text directly into an authority-controlled field,
and if you enter a heading that doesn't currently have an authority record,
an authority record stub is automatically created, and the heading you
entered linked
11. Confirm that if you enter a heading with only a subfield $a that fully
*matches* an existing heading (i.e. the existing heading has only
subfield $a populated), the authid for that heading is inserted into
subfield $9
12. Confirm that if you enter a heading with multiple subfields that *matches*
an existing heading, the authid for that heading is inserted into
subfield $9
13. Turn on BiblioAddsAuthorities and turn off AutoCreateAuthorities
14. Confirm that you can enter text directly into an authority-controlled field,
and if you enter a heading that doesn't currently have an authority record,
an authority record stub is *not* created
15. Confirm that if you enter a heading with only a subfield $a that *matches*
an existing heading, the authid for that heading is inserted into
subfield $9
16. Confirm that if you enter a heading with multiple subfields that *matches*
an existing heading, the authid for that heading is inserted into
subfield $9
17. Create a record and link an authority record to an authorized field using
the authority plugin.
18. Save the record. Ensure that the heading is linked to the appropriate
authority.
19. Open the record. Change the heading manually to something else, leaving
the link. Save the record.
20. Ensure that the heading remains linked to that same authority.
21. Change CatalogModuleRelink to "on."
22. Open the record. Use the authority plugin to link that heading to the
same authority record you did earlier.
23. Save the record. Ensure that the heading is linked to the appropriate
authority.
24. Open the record. Change the heading manually to something else, leaving
the link. Save the record.
25. Ensure that the heading is no longer linked to the old authority record.
*** Testing link_bibs_to_authorities.pl ***
26. Set LinkerModule to "Default," turn on LinkerRelink and
BiblioAddsAuthorities, and turn AutoCreateAuthorities and
LinkerKeepStale off
27. Edit one bib record so that an authority controlled field that has already
been linked (i.e. has data in $9) has a heading that does not match any
authority record in your database
28. Run misc/link_bibs_to_authorities.pl --link-report --verbose --test (you may
want to pipe the output into less or a file, as the result is quite a lot of
information)
29. Look over the report to see if the headings that you have authority records
for report being matched, that the heading you modified in step 2 is
reported as "unlinked," and confirm that no changes were actually made to
the database (to check this, look at the bib record you edited earlier, and
check that the authid in the field you edited hasn't changed)
30. Run misc/link_bibs_to_authorities.pl --link-report --verbose (you may want
to pipe the output into less or a file, as the result is quite a lot of
information)
31. Check that the heading you modified has been unlinked
32. Change the modified heading back to whatever it was, but don't use the
authority control plugin to populate $9
33. Run misc/link_bibs_to_authorities.pl --link-report --verbose
--bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
of the record you've been editing)
34. Confirm that the heading has been linked to the correct authority record
35. Turn LinkerKeepStale on
36. Change that heading to something else
37. Run misc/link_bibs_to_authorities.pl --link-report --verbose
--bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
of the record you've been editing)
38. Confirm that the $9 has not changed
39. Turn LinkerKeepStale off
40. Create two authorities with the same heading
41. Run misc/migration_tools/rebuild_zebra.pl -a -z
42. Enter that heading into the bibliographic record you are working with
43. Run misc/link_bibs_to_authorities.pl --link-report --verbose
--bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
of the record you've been editing)
44. Confirm that the heading has not been linked
45. Change LinkerModule to "FirstMatch"
46. Run misc/link_bibs_to_authorities.pl --link-report --verbose
--bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
of the record you've been editing)
47. Confirm that the heading has been linked to the first authority record it
matches
48. Change LinkerModule to "LastMatch"
49. Run misc/link_bibs_to_authorities.pl --link-report --verbose
--bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
of the record you've been editing)
50. Confirm that the heading has been linked to the second authority record it
matches
51. Run misc/link_bibs_to_authorities.pl --link-report --verbose
--auth-limit="authid=${AUTH}" (replacing ${AUTH} with an authid)
52. Confirm that only that heading is displayed in the report, and only those
bibs with that heading have been changed
If all those things worked, good news! You're ready to sign off on the patch
for bug 7284.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Rebased on latest master and squashed follow-up, 16 February 2012
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Rebased on latest master, 21 February 2012
Signed-off-by: schuster <dschust1 at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Tested with an UNIMARC setup that things work fine. They do
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Cherry-picked onto 3.6.x, 10 March 2012
Note for RMaint: this patch squashes all the bug 7284 patches from Master,
including the updatedatabase changes (but does not set the DB revision).
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list