[koha-commits] main Koha release repository branch new/bug_8919 created. v3.08.00-1179-g24125d4
Git repo owner
gitmaster at git.koha-community.org
Thu Nov 8 18:41:14 CET 2012
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, new/bug_8919 has been created
at 24125d4be39a3b6f19b1b0ae3f51855575a01759 (commit)
- Log -----------------------------------------------------------------
commit 24125d4be39a3b6f19b1b0ae3f51855575a01759
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Mon Oct 15 14:55:05 2012 +0200
Bug 8919 - ExtendedPatronAttributes not populated from LDAP
Current code is overly complex and assumes that
C4::Members::AttributeTypes::GetAttributeTypes
returns array of attribute codes which is not true.
Instead it return array of hashes so none of extended attributes
will be replicated from LDAP.
This code correctly extracts extended attributes from borrower data
provides simpler code which fills same structure.
It also skips empty values (" ") which are result of mapping without
any default value. This is needed to make unique extended patron values
work. If not handled it would insert empty value for first user and
fail for all others on uniqueness constraint.
Test scenario:
1. define Patron attribute types in administration
2. define mapping from LDAP fields to attributes in koha-conf.xml
3. login as new user with LDAP fields and verify that extended
attributes are replicated from LDAP
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Passed-QA-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list