[koha-commits] main Koha release repository branch new/bug_7932 created. v3.08.00-1240-g7f45bb3

Git repo owner gitmaster at git.koha-community.org
Tue Nov 20 13:39:01 CET 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_7932 has been created
        at  7f45bb37dde58991b1b7521c5dac69f6fbd25e67 (commit)

- Log -----------------------------------------------------------------
commit 7f45bb37dde58991b1b7521c5dac69f6fbd25e67
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Nov 1 11:21:37 2012 -0400

    Bug 7932 [Revised] Twitter share doesn't work with socialnetworks
    
    The only way I can get this to work consistently is to use
    Twitter's own code as documented here:
    
    https://dev.twitter.com/docs/tweet-button
    
    This requires that we use the tweet button generated by Twitter
    rather than the smaller image we were using before. Using the
    documented options for generating a custom button produced the
    same inconsistent behavior this patch attempts to fix.
    
    Because of the change of appearance I moved the Twitter button
    to last in line so that similarly-sized buttons were grouped. I
    also changed the configuration of the Google+ button to exclude
    the count, saving some horizontal space.
    
    Revision removes explicit declaration of share URL. I think when
    testing this previously I assumed it was required when in fact
    the share URL wasn't working because it was a localhost address.
    
    Localhost addresses are apparently rejected by Twitter. Testers
    beware.
    
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
    Passed-QA-by: Paul Poulain <paul.poulain at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list