[koha-commits] main Koha release repository branch new/bug_5801 created. v3.08.00-1332-gaf355d1

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_5801 has been created
        at  af355d17f0a3cbdd35bf2a774ad5f89f870be85f (commit)

- Log -----------------------------------------------------------------
commit af355d17f0a3cbdd35bf2a774ad5f89f870be85f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Oct 1 15:16:29 2012 -0400

    Bug 5801 - C4::Circulation::_GetCircControlBranch wrongly used in opac-reserve.pl
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and perlcritic pass.
    
    Tests done:
    holds policy vs. circulation rules seemed to make the difference for me,
    I am not totally sure why that is, but see no reason to fail this patch as
    results are ok.
    
    System preferences
    - CircControlBranch = the library the item is from
    - ReservesControlBranch = patron's home library
    
    Circulation rules
    - Library A - Holds policy: Books can not be put on hold.
    - Library B - Holds policy: Books can be put on hold. (no special setting needed)
    
    Catalog data
    - A record with an item for library B, itemtype Books.
    
    Test without patch:
    
    1) Patron A (home library A) places a hold in OPAC on an item from library B.
    
    Should be: hold is NOT allowed.
    Before patch: hold IS allowed.
    After patch: hold is NOT allowed.
    OK
    
    2) ReserveControlbranch = item's home library
    Patron A (home library A) places a hold in OPAC on an item from library B.
    
    Should be: hold is allowed.
    Before patch: hold is allowed.
    After patch: hold is allowed.
    OK
    
    3) ReservesControlBranch = patron's home library
    Circulation rules: Remove hold policy for library B.
    Library A: no holds allowed for books using 'Holds allowed (count)' = 0
    Library B: 5 holds allowed for books using 'Holds allowed (count)' = 5
    Patron A (home library A) places a hold in OPAC on an item from library B.
    
    Should be: hold is NOT allowed
    Before patch: hold is NOT allowed
    After patch:  hold is NOT allowed
    OK
    
    4) ReserveControlbranch = item's home library
    
    Should be: hold is allowed
    Before patch: hold is allowed
    After patch:  hold is allowed
    OK
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository