[koha-commits] main Koha release repository branch 3.10.x updated. v3.08.00-1367-gbf6ed3d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.10.x has been updated
       via  bf6ed3d51f8e67c5efe3485cff693d0d09e617a4 (commit)
      from  ddf087137eb55aae562749a01309c5906e1097d4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bf6ed3d51f8e67c5efe3485cff693d0d09e617a4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Oct 1 15:16:29 2012 -0400

    Bug 5801 - C4::Circulation::_GetCircControlBranch wrongly used in opac-reserve.pl
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and perlcritic pass.
    
    Tests done:
    holds policy vs. circulation rules seemed to make the difference for me,
    I am not totally sure why that is, but see no reason to fail this patch as
    results are ok.
    
    System preferences
    - CircControlBranch = the library the item is from
    - ReservesControlBranch = patron's home library
    
    Circulation rules
    - Library A - Holds policy: Books can not be put on hold.
    - Library B - Holds policy: Books can be put on hold. (no special setting needed)
    
    Catalog data
    - A record with an item for library B, itemtype Books.
    
    Test without patch:
    
    1) Patron A (home library A) places a hold in OPAC on an item from library B.
    
    Should be: hold is NOT allowed.
    Before patch: hold IS allowed.
    After patch: hold is NOT allowed.
    OK
    
    2) ReserveControlbranch = item's home library
    Patron A (home library A) places a hold in OPAC on an item from library B.
    
    Should be: hold is allowed.
    Before patch: hold is allowed.
    After patch: hold is allowed.
    OK
    
    3) ReservesControlBranch = patron's home library
    Circulation rules: Remove hold policy for library B.
    Library A: no holds allowed for books using 'Holds allowed (count)' = 0
    Library B: 5 holds allowed for books using 'Holds allowed (count)' = 5
    Patron A (home library A) places a hold in OPAC on an item from library B.
    
    Should be: hold is NOT allowed
    Before patch: hold is NOT allowed
    After patch:  hold is NOT allowed
    OK
    
    4) ReserveControlbranch = item's home library
    
    Should be: hold is allowed
    Before patch: hold is allowed
    After patch:  hold is allowed
    OK
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-reserve.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
main Koha release repository