[koha-commits] main Koha release repository branch new/bug_8175 created. v3.08.00-1038-gb8f4b1f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_8175 has been created
        at  b8f4b1fa146650fc9ff6c47be80e1f5a34863a9f (commit)

- Log -----------------------------------------------------------------
commit b8f4b1fa146650fc9ff6c47be80e1f5a34863a9f
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Sun Sep 2 20:46:03 2012 +0800

    Bug 8175 - check logs error or displays incorrectly in details.pl
    
    Changed "$item->{'materials'} ne ''" to
    "defined($item->{'materials'}) && $item->{'materials'} =~ /\S/"
    in if condition to prevent error when it is NULL, and to
    properly capture the intent of printing if there is something
    visible.
    
    Cases tested include NULL, '0', '', ' ', and 'blah' by using
     UPDATE items SET materials=NULL where biblionumber=19158;
    where the biblionumber was chosen randomly, because only NULL
    was in the items.materials field. The NULL case triggers an
    error, but it does display correctly.
    
    The ' ' case displays an apparently empty column, which does not
    seem to be the intent of the flag that is being set. This is why
    a simple $var check is not sufficient.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository