[koha-commits] main Koha release repository branch new/bug_8594 created. v3.08.00-663-g2341bd8

Git repo owner gitmaster at git.koha-community.org
Wed Sep 5 10:20:59 CEST 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_8594 has been created
        at  2341bd876a526bca5bdaff2777b3cb53085979a6 (commit)

- Log -----------------------------------------------------------------
commit 2341bd876a526bca5bdaff2777b3cb53085979a6
Author: Robin Sheat <robin at catalyst.net.nz>
Date:   Wed Aug 8 18:02:13 2012 +0200

    Bug 8594 - prevent the report system from breaking some subqueries
    
    If you had a report query that had a subquery in the fields list, and
    that subquery had a LIMIT specifier, then it would be removed which
    could break your query. This patch prevents this case from breaking by
    ensuring that only a LIMIT that follows the last WHERE in the query is
    removed.
    
    If you don't have a WHERE, then it will behave like it always
    did, removing all the cases of LIMIT (which would still break a subquery
    but this is a) more rare, and b) would require more intelligent parsing
    to deal with.
    
    Also adds test cases and function documentation.
    
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
    
    Tested with this report:
    
    select biblionumber, (select itemnumber from items where items.biblionumber=biblio.biblionumber LIMIT 1) from biblio where biblionumber<1000;
    
    and it worked like a charm
    
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list