[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.04-28-g5a34c64

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  5a34c64b9374a8c3de2658d588e63ed0d828cc6d (commit)
      from  2ab3176015cf3d41aace877885090444e502b2b0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5a34c64b9374a8c3de2658d588e63ed0d828cc6d
Author: Robin Sheat <robin at catalyst.net.nz>
Date:   Wed Aug 8 18:02:13 2012 +0200

    Bug 8594 - prevent the report system from breaking some subqueries
    
    If you had a report query that had a subquery in the fields list, and
    that subquery had a LIMIT specifier, then it would be removed which
    could break your query. This patch prevents this case from breaking by
    ensuring that only a LIMIT that follows the last WHERE in the query is
    removed.
    
    If you don't have a WHERE, then it will behave like it always
    did, removing all the cases of LIMIT (which would still break a subquery
    but this is a) more rare, and b) would require more intelligent parsing
    to deal with.
    
    Also adds test cases and function documentation.
    
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
    
    Tested with this report:
    
    select biblionumber, (select itemnumber from items where items.biblionumber=biblio.biblionumber LIMIT 1) from biblio where biblionumber<1000;
    
    and it worked like a charm
    
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reports/Guided.pm            |   43 ++++++++++++++++--
 t/db_dependent/Reports/Guided.t |   92 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 130 insertions(+), 5 deletions(-)
 create mode 100644 t/db_dependent/Reports/Guided.t


hooks/post-receive
-- 
main Koha release repository