[koha-commits] main Koha release repository branch new/bug_6976 created. v3.08.00-772-g3b60805

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_6976 has been created
        at  3b608056d9cd86375b51d63a56c054fec1f4a16d (commit)

- Log -----------------------------------------------------------------
commit 3b608056d9cd86375b51d63a56c054fec1f4a16d
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Aug 28 14:34:55 2012 +0100

    Bug 6976 Close loophole allowing borrowers extra holds via opac
    
    The check that the max number of reserves has
    not been reached needs to take account of the fact
    that we may have added enouch reserves to
    reach the limit while this script is running.
    Add a check against the incrementing count
    
    The variable canreserve was only used when looping
    through multiple holds but was not being
    reinitialized on every iteration
    make variable local to loop it is used in and
    initialize to zero
    
    Have used perltidy to correct the indention of
    the while loop as it was misleading to the reader
    
    Some numeric comparisons were using a string operator
    fix them before strange bugs manifest themselves
    
    The loophole manifests thus:
    borrowers are only allowed Y holds.
    If holds are done individually, it is
    obeying that law i.e. X has held Y separate books –
     when I tried to do a 6th
    book it told me that I could not place a hold.
    However, if a borrower checks the catalogue,
    gets the intial list up and clicks items on the “results”
    box and then clicks “place hold” they can hold more than Y
    items Please enter the commit message for your changes. Lines starting
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository