[koha-commits] main Koha release repository branch new/bug_6151 created. v3.08.00-813-g9acabe4

Git repo owner gitmaster at git.koha-community.org
Mon Sep 17 19:22:42 CEST 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_6151 has been created
        at  9acabe44a40dbd8aa6ce2662fea174a9ca51f8ae (commit)

- Log -----------------------------------------------------------------
commit 9acabe44a40dbd8aa6ce2662fea174a9ca51f8ae
Author: Paul Poulain <paul.poulain at biblibre.com>
Date:   Mon Sep 17 19:24:45 2012 +0200

    Bug 6151 follow-up, fix HTML4 coding guideline

commit bf61215e9e257fe7a388e44b4f2fcd47cf4a7a51
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Aug 13 16:02:04 2012 -0400

    Bug 6151 - Followup - Change 'itemnumber' to 'barcode'
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

commit 7cbb0debf5eec86b1e7548525ebbeaef601f5ef3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Aug 2 08:23:50 2012 -0400

    Bug 6151 - Followup - Display message for failed returns on circulation.pl when returning via issues table.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit c50a86e55f6d1a68be349c21112e0ae728aff25d
Author: Paul Poulain <paul.poulain at biblibre.com>
Date:   Mon Sep 17 19:18:59 2012 +0200

    Bug 6151 follow-up DBREv & removing useless `

commit 850b4eeab96e4d9f298e67b1987ad9aad5b28fd8
Author: Ian Walls <ian.walls at bywatersolutions.com>
Date:   Thu Dec 1 16:15:04 2011 -0500

    Bug 6151: Add AllowReturnToBranch system preference
    
    In order to solve the issue of IndependantBranches being incompatible with HomeOrHoldingBranchReturn,
    this patch changes the mechanism by which the question "can I return this material here?" is answered.  Before,
    the conditions were "if IndependantBranches is on, and this branch isn't HomeOrHoldingBranchReturn for the item,
    then no, otherwise yes".  Now, the question is answered by consulting CanBookBeReturned (new subroutine)
    
    New system preference:  AllowReturnToBranch
    Possible values:
      - anywhere (default for new installs, and for existing systems with IndependantBranches turned off)
      - homebranch
      - holdingbranch (which is also the issuing branch in all normal circumstances)
      - homeorholdingbranch (default for existing systems with IndependantBranches turned on)
    
    New subroutine:  CanBookBeReturned
    Input:  $item hash (from GetItems), and $branchcode
    Output: 0 or 1 to indicate "allowed" or not, and an optional message if not allowed.  Message is the 'correct' branchcode
    to return the material to
    
    To Test:
    1.  Install patch and new syspref
    2.  Check that default value of the preference:
        - if IndependantBranches was OFF at install time, should be 'anywhere'
        - if IndependantBranches was ON at install time, should be 'homeorholdingbranch'
    
    Case:  'anywhere'
    1.  Checkout a Library A book at Library A.  Return at Library A should be successful
    2.  Repeat step 1, returning to Library B.  Return should be successful
    3.  Checkout a Library A book at Library B.  Return to A should be successful
    4.  Repeat step 3 with Library B and Library C
    
    Case: 'homebranch'
    1.  Checkout a Library A book at Library A.  Return at Library A should be successful
    2.  Repeat step 1, returning to Library B.  Return should FAIL (returning message to return at A)
    3.  Checkout a Library A book at Library B.  Return to Library A should be successful
    4.  Repeat step 3 with Library B and Library C.  Both should FAIL (returning message to return at A)
    
    Case: 'holdingbranch'
    1.  Checkout a Library A book at Library A.  Return at Library A should be successful
    2.  Repeat step 1, returning to Library B.  Return should FAIL (returning message to return at A)
    3.  Checkout a Library A book at Library B.  Return to A should FAIL (returning message to return at B)
    4.  Repeat step 3 with Library B. Return should be successful
    5.  Repeat step 3 with Library C. Return should FAIL (returning message to return at B)
    
    Case: 'homeorholdingbranch'
    1.  Checkout a Library A book at Library A.  Return at Library A should be successful
    2.  Repeat step 1, returning to Library B.  Return should FAIL (returning message to return at A)
    3.  Checkout a Library A book at Library B.  Return to A should be successful
    4.  Repeat step 3 with Library B. Return should be successful
    5.  Repeat step 3 with Library C. Return should FAIL (returning message to return at A)
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list