[koha-commits] main Koha release repository branch new/bug_9571 created. v3.12.00-beta1-138-gb5497a5

Git repo owner gitmaster at git.koha-community.org
Tue Apr 2 14:18:38 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_9571 has been created
        at  b5497a5f46a32c1ab33a22539e8acfcf82e476b0 (commit)

- Log -----------------------------------------------------------------
commit b5497a5f46a32c1ab33a22539e8acfcf82e476b0
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Feb 8 13:49:16 2013 +1100

    Bug 9571 - Fix width for textareas in Edit Item screen
    
    This patch adds a style for textareas on the Edit Item screen of addbiblio.pl so that they are roughly the same length as the other input elements around it on the page.
    
    To test:
    
    Before applying patch...
    
    1) Create a new item for any biblio with a URL (subfield u) of over 100 characters (you can use www.lettercount.com to count the number of characters in your URL).
    2) In any browser (I've already looked at IE, Firefox, and Chrome on Windows), edit the item (either by clicking "Edit Items" from the Normal view of the bib record then clicking "Edit" next to the applicable item, or clicking on the "Items" view in the bib record and clicking "Edit item" next to the relevant item).
    3) Notice that the textarea for the url is absolutely tiny. Difficult to read and difficult to interact with.
    
    Apply patch.
    
    1) Notice that the textarea is roughly the same size as the other input elements on the page.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 9b242afd75b68ed06372db95a1b46435d918871d
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Feb 8 11:21:11 2013 -0500

    Bug 9571 [Alternate] Fix width for textareas in Edit Item screen
    
    This alternative patch modifies the script where the input markup is
    built and adds an alternative configuration for textareas. This gives
    the textareas explicit "cols" and "rows" attributes. I think this
    solution is preferable to a style fix because it solves the bug while
    eliminating some invalid markup (no "size" or "maxlength" attributes on
    textareas, which are invalid without explicit dimensions).
    
    To test, add a nice big chunk of text to an existing item's item field
    like "Public note" (952$z), save, and edit again. The field should now
    be displayed in a more comfortably-sized textarea.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 6dd36b7fa7410492b73f3d09b0fd28d9f615f5e4
Merge: 9c0b2e4 c389de0
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Tue Apr 2 08:17:40 2013 -0400

    Merge branch 'bug_9952' into 3.12-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list