[koha-commits] main Koha release repository branch new/bug_8770 created. v3.12.00-beta1-201-g93f6053

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_8770 has been created
        at  93f60536947c06c325ec010c5e6dd6c9dd24ca79 (commit)

- Log -----------------------------------------------------------------
commit 93f60536947c06c325ec010c5e6dd6c9dd24ca79
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Apr 3 13:05:52 2013 -0400

    Bug 8770 - amount does not equal amountoutstanding on a fine with no payments or credits
    
    If a lost item fee is owed and partially paid off when an item is
    returned and a refund is processed, Koha tries to pay off existing
    fees before adding any leftover balance as a credit on the account.
    
    However, those fee payments aren't actually processed, due to a bug
    where the accountnumber was quoted as a string literal, and thus the
    for the fee payment would fail. This did not result in an DB error,
    as the query was still valid SQL. Checking the return value of the
    query would have revealed that the accountline had not been updated.
    
    History:
    This bug was introduced on April 23, 2007 with the commit
    'reintroducing fixaccountforlostandreturned as requested by rosalie'.
    Commit id 111d590e9cdaf801256822e23f170bfc2365338f
    
    On July 30, 2009 the error was flagged with a FIXME and remained
    in that state until now.
    Commit id 51e8fc2cb6a0cf79f19206c822a4361aeca6f63f
    
    Test plan:
    1) Create a test patron
    2) Check out an item to that patron and give it a due date in the past
    3) Run fines.pl to generate the fine for the item
    4) Mark the item long overdue on the item tab (not in edit items)
    5) Pay for the lost item
    6) Check the item back in
    7) Note the incorrect fines. Only the lost fee balance  due is refunded,
       not the entire lost fee, but no other fees are paid off.
    8) Apply the patch
    9) Repeat steps 1-6, then not the fines are paid correctly
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Totel due is correct after applying the patch.
    All tests and QA script pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository