[koha-commits] main Koha release repository branch new/bug_9737 created. v3.12.00-beta1-230-g2e47475

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_9737 has been created
        at  2e4747566457d807fef88dff8332c3db18b86b49 (commit)

- Log -----------------------------------------------------------------
commit 2e4747566457d807fef88dff8332c3db18b86b49
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Mar 1 13:22:33 2013 +1100

    Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists
    
    The current problem:
    
    When the verify_images() function runs from amazonimages.js, it loops
    through every img element and selects the elements that come from Amazon
    sources.
    
    However, if the height/width is 1 (i.e. Amazon passes off a blank image)
    or if the img element's complete property is null or non-existent, then
    it searches for the parent node and re-writes the HTML with the "No
    Cover Image Available" (NO_AMAZON_IMAGE) text, even though that parent
    node might contain other img elements that have images available (from
    Google, local images, etc)!
    
    Proposed fix:
    
    Wrap the Amazon image in a span tag (as we do with the Google and local
    covers), so that it re-writes the HTML within that parent span, rather
    than the parent anchor which contains all the other images.
    
    To test:
    
    1) Turn on the OPACAmazonCoverImages, GoogleJackets, and
       OPACLocalCoverImages system preferences
    2) Replace the ISBN in one of your records with 9780615352435
    3) Now load a local cover image for that record
    4) Search for that record (but make sure you're vague enough to have
       multiple search results)
    5) For a split second, you may notice the local cover image appears before being replaced by a "No Cover Image Available".
    
    Now apply this patch
    
    6) Refresh your search results page
    7) You should now see your local cover image, PLUS the "No Cover Image
       Available" for the Amazon image, and whatever other graphics/"no
       cover image available" "graphics" for the Google Jackets.
    
    To be comprehensive, try the same set of steps using the OPAC Lists
    rather than the OPAC Search Results
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 23f14a718049100dafb1580839dc869d3c1028ba
Merge: e4fec07 e3a9d49
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Thu Apr 18 07:55:27 2013 -0400

    Merge branch 'bug_9894' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository