[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.00-beta1-218-g2372f3f
Git repo owner
gitmaster at git.koha-community.org
Thu Apr 18 14:27:56 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.12.x has been updated
via 2372f3f422607a40c3efd675beb0e5d6b614a516 (commit)
via 4969a924eefd6e93ca4971b29554ea078a270d23 (commit)
via 6f3e4a344d1134fddd2a0c776e1b0b5cba8f0443 (commit)
via b95f9f2e9de5c2ac7b252da5eb04eee3f34e8fe5 (commit)
via 5c5cf485f77df8ed42687668357790d5e77788c6 (commit)
via 0d7e8397949e4a394ad308458aa1408e8fdf331f (commit)
via d953330264a5b56bedf59a68b2086f3d3b0b6c90 (commit)
from e468eb177be4176534256c48cdd021b6180eb3d8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2372f3f422607a40c3efd675beb0e5d6b614a516
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Apr 8 09:32:08 2013 -0400
Bug 9997 - Suspected typo in patron self registration code
String fix. The field name is also incorrect, causing the alternate
contact country to not be stored.
To test: Submit an update to an existing patron record an include a
change to the alternate contact's country field. Before the patch this
line would not appear in the staff client for approval. After the patch
it should.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Reminder: Even small patches require test plans. I have added one which
I think covers the changes in the patch.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
(cherry picked from commit 3cd8189fa862164a64215a8c1d8690645c5397f2)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 4969a924eefd6e93ca4971b29554ea078a270d23
Author: David Cook <dcook at prosentient.com.au>
Date: Fri Mar 1 13:22:33 2013 +1100
Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists
The current problem:
When the verify_images() function runs from amazonimages.js, it loops
through every img element and selects the elements that come from Amazon
sources.
However, if the height/width is 1 (i.e. Amazon passes off a blank image)
or if the img element's complete property is null or non-existent, then
it searches for the parent node and re-writes the HTML with the "No
Cover Image Available" (NO_AMAZON_IMAGE) text, even though that parent
node might contain other img elements that have images available (from
Google, local images, etc)!
Proposed fix:
Wrap the Amazon image in a span tag (as we do with the Google and local
covers), so that it re-writes the HTML within that parent span, rather
than the parent anchor which contains all the other images.
To test:
1) Turn on the OPACAmazonCoverImages, GoogleJackets, and
OPACLocalCoverImages system preferences
2) Replace the ISBN in one of your records with 9780615352435
3) Now load a local cover image for that record
4) Search for that record (but make sure you're vague enough to have
multiple search results)
5) For a split second, you may notice the local cover image appears before being replaced by a "No Cover Image Available".
Now apply this patch
6) Refresh your search results page
7) You should now see your local cover image, PLUS the "No Cover Image
Available" for the Amazon image, and whatever other graphics/"no
cover image available" "graphics" for the Google Jackets.
To be comprehensive, try the same set of steps using the OPAC Lists
rather than the OPAC Search Results
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
(cherry picked from commit 2e4747566457d807fef88dff8332c3db18b86b49)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 6f3e4a344d1134fddd2a0c776e1b0b5cba8f0443
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Apr 4 09:47:25 2013 +0200
Bug 9894: Add labels for checkboxes
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
(cherry picked from commit e3a9d492cc5ca142784c3e385867cd5a04b26ce8)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b95f9f2e9de5c2ac7b252da5eb04eee3f34e8fe5
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Apr 3 15:50:49 2013 -0300
Bug 9894 - (3.12) Small followup
Liz's patch adds the 'flagged' value back, but there's a problem with its logic that prevents it to work on startup (works fine for changing values)
Regards
To+
Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
(cherry picked from commit a0680d0ca2ff9c7b087cd995b85d5614d902e2d9)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 5c5cf485f77df8ed42687668357790d5e77788c6
Author: Liz Rea <liz at catalyst.net.nz>
Date: Fri Mar 29 22:33:33 2013 +1300
Bug 9894 - Followup: Add support for "flagged" values
Even though we don't know what they mean or do.
To test:
- open the docs to have at hand the list of codes/visibility options combinations and
try changing several subfields from a single tagfield. Save, and reopen the "Edit subfields" page.
- Click the "Flagged" checkbox - it should disable the other checkboxes as this setting is (apparently) exclusive to the others.
- Step through several tabs and set your visibilities as you like.
- I had a MySQL shell opened to repeatedly run this query (i tested against field 886
on the default framework):
> SELECT tagfield,tagsubfield,hidden FROM marc_subfield_structure WHERE frameworkcode='' AND tagfield=886;
- Compare what was saved on the DB with the docs for that visibility selection.
Bug 9894 - Help file updates
To test:
Click the Help link in the upper right hand corner of the MARC subfield editor
Verify that the epic list of values is gone
Verify that the help page overall looks alright
Verify that the help makes sense and is understandable.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
(cherry picked from commit 0a91a071efa49b77ca1ff2923aafbd9de1a1a481)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 0d7e8397949e4a394ad308458aa1408e8fdf331f
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Mar 25 22:55:11 2013 -0300
Bug 9894 - (3.12) de-serialize the 'hidden' value for subfields in frameworks
This patch aims to provide a non-intrusive way (with respect to Koha's code, so
it could have got into 3.12) for the users to easily choose the visibility settings
for each subfield.
This patch is also known to have arrived late for 3.12. I've been struggling with
other stuff at work, but I just wanted to put this somewhere just in case it can
be reused or something else.
The patch adds two JavaScript functions that deal with (de)serialization of the 'hidden'
value for subfields. One each way. Listeners are added to the checkboxes so the (actually, heh)
'hidden' value gets correctly updated on each checkbox change.
There's a costly function to update all checkboxes on every tab to match the 'hidden' value on page load.
To test:
- open the docs to have at hand the list of codes/visibility options combinations and
try changing several subfields from a single tagfield. Save, and reopen the "Edit subfields" page.
- I had a MySQL shell opened to repeatedly run this query (i tested against field 886
on the default framework):
> SELECT tagfield,tagsubfield,hidden FROM marc_subfield_structure WHERE frameworkcode='' AND tagfield=886;
- Compare what was saved on the DB with the docs for that visibility selection.
Regards
To+
PS: I promise I'll work on the proper patch for 3.14, which would involve DB structure changes and
(more than I expected) rewriten code.
Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
I promise to hug you the next time we meet. This works, and is a reasonable work around for a very longstanding awkward interface.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
(cherry picked from commit 557857cf2c881fb7beec2019d3c85cef893c5342)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit d953330264a5b56bedf59a68b2086f3d3b0b6c90
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Tue Apr 16 11:07:19 2013 +1200
Bug 10061 - Fix tinymce path references broken by bug 9172
Only affects the package builds
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 15f58c257f8830dffb7b7d565f868f4614f2063d)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
-----------------------------------------------------------------------
Summary of changes:
debian/rules | 5 +-
.../en/modules/admin/marc_subfields_structure.tt | 153 +++++++++++++++++++-
.../modules/help/admin/marc_subfields_structure.tt | 35 ++----
.../prog/en/modules/members/members-update.tt | 2 +-
.../opac-tmpl/prog/en/modules/opac-results.tt | 6 +-
.../opac-tmpl/prog/en/modules/opac-shelves.tt | 6 +-
6 files changed, 170 insertions(+), 37 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list