[koha-commits] main Koha release repository branch new/bug_10049 created. v3.12.00-beta1-280-g6910bec

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10049 has been created
        at  6910bec11677bbee4e29a4c79587cbcf60c28e85 (commit)

- Log -----------------------------------------------------------------
commit 6910bec11677bbee4e29a4c79587cbcf60c28e85
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Apr 15 09:23:58 2013 -0400

    Bug 10049 [Alternate] Comments tab shows ( ) instead of ( 0 ) on translated templates
    
    This patch is an alternate solution to the problem of "0" not appearing
    on the comment tab in translated templates. It uses the Template Toolkit
    option of specifying a default value for a variable:
    
    [% reviews.size || 0 %]
    
    This syntax is already in use elsewhere in the template.
    
    Same test plan:
    
    1) Make sure comments/reviews are activated
    2) Find a record with 0 comments/reviews in the opac
    3) The tab shows: Comments ( 0 )
    4) Switch to any other languages.
    5) Tab now shows: <translation of Comments> ( )
    6) Apply patch
    7) Check English templates stil work correctly
    8) Rerun 'perl translate install <langcode>
    9) Check display is now correct.
    10) Also check that number shows correctly for records
        with comments.
    
    Signed-off-by: Magnus Enger <magnus at enger.priv.no>
    Tested with nb-NO. English still works after the patch. Norwegian
    was showing "Comments" untranslated, which had me a bit unnerved.
    Turns out the string to be translated changed from "Comments ( %s%s%s%s )"
    to "Comments ( %s )", so to make sure all was well, I had to update
    the nb-NO translation, fix the number of %s's in the Norwegian string,
    make sure it was not marked as fuzzy and then install nb-NO. And it
    works!
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 0a67a0c043c405ae27baad69b6b0cc6a477064c3
Merge: 2c3b582 a986c92
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Sun Apr 21 09:57:10 2013 -0400

    Merge branch 'bug_9839' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository