[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.12-2-gc3acf92

Git repo owner gitmaster at git.koha-community.org
Thu Apr 25 00:07:12 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  c3acf92ac8d105b2a063067a76ec01ed20bbfb0e (commit)
      from  2f2ec10b467d705c3333e02d61215e6d937e4305 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c3acf92ac8d105b2a063067a76ec01ed20bbfb0e
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date:   Thu Jan 24 17:11:31 2013 +0100

    Bug 9484: userid not generated consistently (different editing pages)
    
    When modifying a patron through different pages, the userid
    generation does not behave always the same way; this patch
    corrects this:
    - when firstname and surname are present in the form, they
    are used for the generation;
    - if there are not in the form, the firstname and surname
    in database are used instead.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Comment: Work as described. No errors.
    Test
    This patch lacks a test plan, so I do the following
    1) New user, empty userid, autocompleted
    2) Edit user, change userid, saved correctly
    3) Edit user, main edit window, emptied userid, autocompleted
    4) Edit user, Detail > Library use, emptied userid, not autocomplete (not even a dot)
    5) Applied patch
    6) Repeated 1-3, same behavior
    7) Repeated 4), now autocompletes with same userid as 3)
    
    So, works as described.
    No koha-qa errors.
    
    NOTE: It's impossible now to delete userid from interface.
    
    Off-topic: tried an userid in Arabic, works very well.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 members/memberentry.pl |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list