[koha-commits] main Koha release repository branch new/bug_9659 created. v3.12.00-beta1-350-g1f9145b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_9659 has been created
        at  1f9145bbbdf020e18a4e0a49652a9cf55f6bed20 (commit)

- Log -----------------------------------------------------------------
commit 1f9145bbbdf020e18a4e0a49652a9cf55f6bed20
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Fri Apr 26 08:08:07 2013 -0400

    Bug 9659: Move new unit test to db-dependent directory
    
    C4::Reports::Guided requires a koha-conf.xml file to be in place in
    order to load. This means that any test which uses it has to go in
    t/db_dependent
    
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 6110375307845778f74d6e5a214d63ab69cc5330
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Apr 10 15:50:50 2013 -0300

    Bug 9659 - QA Follow up: Unit tests
    
    Added some tests against the methods added by this patch.
    
    To test, prove -v
    - t/Koha.t
    - t/ReportsGuided.t
    
    Edit: fixed the amount of tests in the skip block. Tests fail for people having earlier versions of DBD::Mock.
    
    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works quite nicely!
    All tests and QA script pass.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit cdc5e11159c6c3dba8ae371094633feb5e64b57d
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Tue Feb 19 15:58:53 2013 -0300

    Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports
    
    A user might create a SQL report that relies on non-existent authorised value categories.
    Because of a typo, or just because they copy&pasted the report from the Wiki.
    
    Use cases are:
    
    - The user creates a report from SQL
      a) Uses bad authorised values
      b) Clicks 'Save Report'
      c) Koha lists the problematic authorised values
      d) The user decides to
      e-1) Save it anyway, it gets saved
      e-2) Edit the report, it gets back to where it chose 'Save Report'
    
    - The user edits an already saved report (Update SQL)
      a) Uses bad authorised values
      b) Clicks 'Update SQL'
      c) Koha lists the problematic authorised values
      d) The user decides to
      e-1) Save it anyway, it gets saved
      e-2) Edit the report, it gets back to where it chose 'Update SQL'
    
    - The user tries to run a saved report that contains bad authorised values, Koha advertises the problem and provides the user with a button 'Edit SQL' to fix things.
    
    To test, just create a report from SQL using invalid authorised values like this (misspelled 'branch'):
    
    SELECT *
    FROM itemtypes
    WHERE hola=<<Test branch1|branchee>> AND
          hola2=<<Test branch2|brancha>>
    
    Regards
    To+
    
    Notes:
    - I added several comments on the code.
    - Fixed an annoying warning of uninitialised variable also (refactored some tiny bits to do it).
    - Added the following methods
       -  C4::Reports::Guided::GetReservedAuthorisedValues
       -  C4::Reports::Guided::GetParametersFromSQL
       -  C4::Reports::Guided::IsAuthorisedValueValid
       -  C4::Reports::Guided::ValidateSQLParameters
       -  C4::Koha::IsAuthorisedValueCategory
    - Those methods could have been used to refactor this guided reports code as its *a bit messy*. I chose to do it in a new bug of course :-D.
    - Fixed some trivial perlcritic -5 errors
    - Removed some debugging stuff left by mistake
    - Fixed some POD problems
    - Optimal SQL-driven IsAuthorisedValueCategory method
    - Thanks to Owen and Jared for their patience heh.
    
    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Comment: Work as described. No koha-qa errors.
    
    Test:
    Tried with examples (from help and test plan) reports, correctly
    identifies invalid authorized values, and no problem with
    authorized ones.
    
    NOTE: Online help for this does not states that partial values
    need to be between '%' in a SQLish way. Perhaps this could be
    addressed inserting % in values or adding a checkbox (partial|exact).
    Or changing help.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit b60a81111048a03591c455134b2b311c644d8754
Merge: 9e70efd 545573d
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Fri Apr 26 07:55:53 2013 -0400

    Merge branch 'bug_10107' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository