[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.00-beta1-302-ga80ef2b

Fri Apr 26 14:24:48 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  a80ef2bc9877c1de54eeb0ed6c980290e0d9f53d (commit)
       via  9522316ce2e7382ced1f70f4d462f14d8b0bbaa2 (commit)
       via  041beaa1d4932b022ea34de7789e74b2ae586977 (commit)
       via  f4c72bbc2aa660ba2c72a06fe7c3f9a3ff6ded15 (commit)
       via  b391e79c2e30b7feaa984c0fd835f97ac88b6221 (commit)
       via  5bff5aa448c921fb67879924a54b3704f5485eb1 (commit)
      from  0d5916987e3320b2c52b8bb41cfd7e5a9015e751 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a80ef2bc9877c1de54eeb0ed6c980290e0d9f53d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Dec 5 13:55:00 2012 -0500

    Bug 9219 - Show damaged and lost statuses for issues on circulation.pl as they are on moremember.pl

    This patch adds the lost and damaged status for an issued item to the
    table of issued items on circulation.pl to make it align more closely to
    the same table on moremember.pl

    Test Plan:
    1) Apply patch
    2) Issue an item
    3) Set the item's damaged status
    4) Verify the status is showing near the date due on circulation.pl
    5) Clear the damaged status and set the lost status again
    6) Repeat step 4

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I could only test this with the DAMAGED value, because
    currently lost items are removed from the patron account
    when you set the status.
    I know there is a patch somewhere
    to make it optional and the change looks alright.
    Passes all tests and QA script.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    (cherry picked from commit 6385cfd1dc6c0dbceed0064c35f6f86f86e22be2)

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 9522316ce2e7382ced1f70f4d462f14d8b0bbaa2
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Fri Apr 26 08:08:07 2013 -0400

    Bug 9659: Move new unit test to db-dependent directory

    C4::Reports::Guided requires a koha-conf.xml file to be in place in
    order to load. This means that any test which uses it has to go in
    t/db_dependent

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    (cherry picked from commit 1f9145bbbdf020e18a4e0a49652a9cf55f6bed20)

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 041beaa1d4932b022ea34de7789e74b2ae586977
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Apr 10 15:50:50 2013 -0300

    Bug 9659 - QA Follow up: Unit tests

    Added some tests against the methods added by this patch.

    To test, prove -v
    - t/Koha.t
    - t/ReportsGuided.t

    Edit: fixed the amount of tests in the skip block. Tests fail for people having earlier versions of DBD::Mock.

    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works quite nicely!
    All tests and QA script pass.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    (cherry picked from commit 6110375307845778f74d6e5a214d63ab69cc5330)

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit f4c72bbc2aa660ba2c72a06fe7c3f9a3ff6ded15
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Tue Feb 19 15:58:53 2013 -0300

    Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports

    A user might create a SQL report that relies on non-existent authorised value categories.
    Because of a typo, or just because they copy&pasted the report from the Wiki.

    Use cases are:

    - The user creates a report from SQL
      a) Uses bad authorised values
      b) Clicks 'Save Report'
      c) Koha lists the problematic authorised values
      d) The user decides to
      e-1) Save it anyway, it gets saved
      e-2) Edit the report, it gets back to where it chose 'Save Report'

    - The user edits an already saved report (Update SQL)
      a) Uses bad authorised values
      b) Clicks 'Update SQL'
      c) Koha lists the problematic authorised values
      d) The user decides to
      e-1) Save it anyway, it gets saved
      e-2) Edit the report, it gets back to where it chose 'Update SQL'

    - The user tries to run a saved report that contains bad authorised values, Koha advertises the problem and provides the user with a button 'Edit SQL' to fix things.

    To test, just create a report from SQL using invalid authorised values like this (misspelled 'branch'):

    SELECT *
    FROM itemtypes
    WHERE hola=<<Test branch1|branchee>> AND
          hola2=<<Test branch2|brancha>>

    Regards
    To+

    Notes:
    - I added several comments on the code.
    - Fixed an annoying warning of uninitialised variable also (refactored some tiny bits to do it).
    - Added the following methods
       -  C4::Reports::Guided::GetReservedAuthorisedValues
       -  C4::Reports::Guided::GetParametersFromSQL
       -  C4::Reports::Guided::IsAuthorisedValueValid
       -  C4::Reports::Guided::ValidateSQLParameters
       -  C4::Koha::IsAuthorisedValueCategory
    - Those methods could have been used to refactor this guided reports code as its *a bit messy*. I chose to do it in a new bug of course :-D.
    - Fixed some trivial perlcritic -5 errors
    - Removed some debugging stuff left by mistake
    - Fixed some POD problems
    - Optimal SQL-driven IsAuthorisedValueCategory method
    - Thanks to Owen and Jared for their patience heh.

    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

    Comment: Work as described. No koha-qa errors.

    Test:
    Tried with examples (from help and test plan) reports, correctly
    identifies invalid authorized values, and no problem with
    authorized ones.

    NOTE: Online help for this does not states that partial values
    need to be between '%' in a SQLish way. Perhaps this could be
    addressed inserting % in values or adding a checkbox (partial|exact).
    Or changing help.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    (cherry picked from commit cdc5e11159c6c3dba8ae371094633feb5e64b57d)

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit b391e79c2e30b7feaa984c0fd835f97ac88b6221
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Apr 24 11:40:18 2013 -0300

    Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC

    This bug is present in master and (at least 3.8.x, where we spotted it).
    The patch makes adding items, to a list from the results page, not rely
    only on opacbookbag syspref but also 'virtualshelves'.

    Regards
    To+

    PS: Thanks Graciela Galli for reporting.

    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Template only patch, works nicely.
    Test plan copied from bug report:

    - Disable the opacbookbag syspref
    - Login in the OPAC
    - Create a list (I tested a private one)
    - Search in your db for some biblios.
    - Choose some and add them to the created list
    - Go to your users's page, to the my lists tab
    - Your list is empty.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    (cherry picked from commit 545573d33318a37e5f58f053acc3a5cf09a9260c)

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 5bff5aa448c921fb67879924a54b3704f5485eb1
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 25 08:49:51 2013 -0400

    Bug 10115 - Hiding advanced search in Orders search tab removes plus button

    The logic of the JavaScript for showing and hiding additional options in
    the orders search form wasn't quite right, resulting in the +/- control
    being hidden incorrectly.

    This patch corrects and simplifies the JS in order to fix the problem.

    To test:
     - Open any page in Acquisitions which shows the orders search
       form in the header search bar (for instance, Acquisitions home).
     - Open the orders search tab and click on the "+" to show more
       options.
     - Click the "-" to hide the additional options. The additional options
       should now be hidden and the "+" displayed.

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
    Works as expected
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    (cherry picked from commit f8130fb8486a3bb840d37006ddfbf046cb9b161a)

    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                                         |   23 +++
 C4/Reports/Guided.pm                               |  127 +++++++++++++---
 .../prog/en/includes/acquisitions-search.inc       |    4 +-
 .../prog/en/modules/circ/circulation.tt            |   22 +++
 .../en/modules/reports/guided_reports_start.tt     |   87 +++++++++--
 .../opac-tmpl/prog/en/modules/opac-results.tt      |    2 +-
 reports/guided_reports.pl                          |  170 ++++++++++++++------
 t/Koha.t                                           |   36 ++++-
 t/db_dependent/ReportsGuided.t                     |  110 +++++++++++++
 9 files changed, 497 insertions(+), 84 deletions(-)
 create mode 100755 t/db_dependent/ReportsGuided.t

hooks/post-receive
-- 
main Koha release repository