[koha-commits] main Koha release repository branch new/bug_9886 created. v3.12.00-beta1-362-g4b1c71e

Git repo owner gitmaster at git.koha-community.org
Sat Apr 27 00:31:22 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_9886 has been created
        at  4b1c71e91a19fcf37e302bba66019807b18cb307 (commit)

- Log -----------------------------------------------------------------
commit 4b1c71e91a19fcf37e302bba66019807b18cb307
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Mar 21 13:56:01 2013 +0100

    Bug 9886: ParseLetter removes too often punctuation characters from fields
    
    This patch makes ParseLetter somewhat more restrictive in removing
    punctuation characters from the end of a table field.
    Based on the assumption that we want to remove punctuation from fields in
    biblio and biblioitems (like ISBD).
    ParseLetter should not remove e.g. a parenthesis in itemcallnumber, but still
    removes e.g. a colon (:) at the end of a title.
    Removed an unneeded global and lookahead from the regex.
    
    Test plan:
    1) Add a colon (:) to the end of a title.
    2) Add a colon to the end of item copynumber.
    3) Place a hold on that item. Check it in. Confirm hold.
    4) Check the email or print notice generated. There should be no colon at the
    end of the title, but the colon in the copynumber should still be there.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I compared checkout notices with lots of different fields before
    and after applying the patch. For example the ) at the end of a
    field in branches is now longer removed. Other fields looked ok
    before and after.
    Passes all tests and QA script.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 12fd63da99b5d217e4537e3f346f1730997ec084
Merge: 86f3175 109f316
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Fri Apr 26 18:35:56 2013 -0400

    Merge branch 'bug_9671' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list