[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-891-gb874f7d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b874f7d63894693c9c3f2a3d93ee119bc3b01486 (commit)
      from  82e1a1c1b39eb497a0ecf8742b2c1b272439b2b6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b874f7d63894693c9c3f2a3d93ee119bc3b01486
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Wed Jul 31 11:39:45 2013 +0200

    Bug 10666: avoid random failures of Daily quotes tests
    
    In t/db_dependent/Koha.t, the test "Got a quote based on today's
    date" is failing :
    
    $prove t/db_dependent/Koha.t :
    t/db_dependent/Koha.t .. 1/6
        #   Failed test 'Got a quote based on today's date.'
        #   at t/db_dependent/Koha.t line 126.
        # Compared $data->{"source"}
        #    got : 'Herbert Hoover'
        # expect : 'Abraham Lincoln'
        # Be sure to run this test on a clean install of sample data.
        # Looks like you failed 1 test of 4.
    
    Looks like the wrong quote is returned by GetDailyQuote().
    I'm using a databased created with the English sample SQL datas.
    
    I think I found the cause :
    The test "Got a random quote." calls GetDailyQuote('random'=>1) which
    changes the quote timestamp to now. When then testing GetDailyQuote(),
    this quote (which may not be the one created by test) is the most
    recent quote.
    
    This patch moves the "Got a random quote." test after "Got a quote
    based on today's date" to solve the problem.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/Koha.t |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository