[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-931-ge476378
Git repo owner
gitmaster at git.koha-community.org
Fri Aug 16 16:27:45 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e476378323eb8dd31e67e4741d271d88de61b59e (commit)
via a9a3bb7b3d7e8e862cf0f772246667258a20b786 (commit)
from 0648d2883d195806eda5a7b91b1b0d6eee7dd87a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e476378323eb8dd31e67e4741d271d88de61b59e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Aug 16 07:21:10 2013 -0400
Bug 10664 [QA Followup] - fix error in overdue_notices.pl if there is no active currency
Fixes the following koha-qa.pl error:
FAIL misc/cronjobs/overdue_notices.pl
OK pod
OK forbidden patterns
OK valid
FAIL critic
# Variables::ProhibitConditionalDeclarations:
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit a9a3bb7b3d7e8e862cf0f772246667258a20b786
Author: Sophie Meynieux <sophie.meynieux at biblibre.com>
Date: Wed Jul 31 08:04:25 2013 +0200
Bug 10664: fix error in overdue_notices.pl if there is no active currency
If there is no active currency, when running overdue_notices.pl
you get a sofware error "Can't use an undefined value as a HASH
reference" on GetCurrency() function call.
With this patch, if there is no active currency, fines are formated
by default 0.00 and notices are correctly generated.
Test plan :
- have at least one borrower with overdue that should trigger a notice
- verify that there is no active currency (Adminitration > Currency &
Exchange rates)
- run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly
on output)
=> without the patch you get the software error
=> with the patch, notices are correctly generated
If an active currency is defined, the script overdue_notices.pl runs
the same with or without patch
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
misc/cronjobs/overdue_notices.pl | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list