[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-946-gd1b3e4a
Git repo owner
gitmaster at git.koha-community.org
Fri Aug 16 18:10:39 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d1b3e4ab6b432844e076e1eb0662a9c04a5f412e (commit)
from 9bc53a0fccc3b673dca43791ebfcb53fd6e0a9ee (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d1b3e4ab6b432844e076e1eb0662a9c04a5f412e
Author: root <root at kenza-VirtualBox>
Date: Thu Jul 25 13:47:09 2013 +0200
Bug 10642: fix inappropriate uses of $sth->finish() in C4::RotatingCollections.pm
From the man page
finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.
Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.
To test:
Verify that prove -v t/db_dependent/RotatingCollections.t passes
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl, passes UT provided by bug 10653
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/RotatingCollections.pm | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list