[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-976-g90e90a4

Wed Aug 21 16:36:01 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  90e90a436ac009014abef0c557ea371b42b124d0 (commit)
       via  e189d4166e852118c1bf3b340991bf8fa0e3b720 (commit)
       via  b559b28fd03a70c37c04b31c8c67755458a01e51 (commit)
       via  2d6bd4b741ed96ad07a68446258d07af234cdc4f (commit)
       via  edf5467469af22c56f2cfc0fed533d19c8da1faa (commit)
       via  fb2bcc05c11fbcd3ca2a0dce1f660836d27f6f69 (commit)
       via  0d88109018637ee294f9012cbe53498422e53292 (commit)
       via  300918e4886433f9f5b52779d8cf2027fcbdcb1a (commit)
      from  d46657f8af980524a4351e40abe0b901d1af3e6a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 90e90a436ac009014abef0c557ea371b42b124d0
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Aug 21 14:45:41 2013 +0000

    Bug 10761: (follow-up) use explicit return in C4::Reports::Guided::delete_report()

    Now that we care about the return value of this routine, we'll keep
    perlcritic happy.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit e189d4166e852118c1bf3b340991bf8fa0e3b720
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Aug 21 11:01:37 2013 +0200

    Bug 10761: (follow-up) change return in C4::Reports::Guided::delete_report()

    1/ delete_report should return undef is no parameter is given.
    2/ delete_report returns the number of affected rows.
    3/ delete_report should be tested with 1 and more parameters.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit b559b28fd03a70c37c04b31c8c67755458a01e51
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Mon Aug 19 15:20:59 2013 +0200

    Bug 10761: UT: add unit tests for save_report and delete_report in C4::Reports::Guided

    The test are wrapped in a transaction.

    Note : The last test (in comment) currently doesn't pass because it
    needs some modifications of delete_report.

    To test:
    prove t/db_dependent/Reports_Guided.t
    t/db_dependent/Reports_Guided.t .. ok
    All tests successful.
    Files=1, Tests=7,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.28 cusr  0.02 csys =  0.32 CPU)
    Result: PASS

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works nicely, tested with patch for bug 10761 applied.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 2d6bd4b741ed96ad07a68446258d07af234cdc4f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Aug 21 10:35:02 2013 +0200

    Bug 3134: (follow-up) Reindent delete_report

    The first patch add a bad indentation for this routine. This patch fixes
    that.

    Also, the $sth->finish statement is useless and was removed.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit edf5467469af22c56f2cfc0fed533d19c8da1faa
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Aug 21 10:27:08 2013 +0200

    Bug 3134: (follow-up) improve ID and peport name sorting on saved reports page

    The sort for ID is alpha instead of numerical, same for the report
    names.

    To test:
    create id=1, name=Report 1
    create id=2, name=Report 2
    create id=10, name=Report 10
    create id=11, name=Report 11

    Sorting by id:
    without this patch 1, 10, 11, 2
    with this patch: 1, 2, 10, 11

    Sorting by name:
    without this patch: Report 1, Report 10, Report 11, Report 2
    with this patch: Report 1, Report 2, Report 10, Report 11

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit fb2bcc05c11fbcd3ca2a0dce1f660836d27f6f69
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Aug 21 10:23:11 2013 +0200

    Bug 3134: highlight all selected reports when confirming deletion of multiple reports

    This patch adds the same behavior when deleting 1 or more reports.
    When checkboxes are checked and the "delete selected" button is pressed,
    checked lines are hightlighted in red.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 0d88109018637ee294f9012cbe53498422e53292
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Aug 19 10:16:21 2013 -0400

    Bug 3134: [Follow-up] Ability to select multiple reports to delete at once

    This follow-up moves the checkboxes into a separate column from the
    report ID in order to prevent visual inconsistencies.

    To test, repeat the test plan from the original patch:

    You must have two or more saved reports to delete. Deletion
    should work properly when:

    - Selecting one report for deletion by checking the box.
    - Selecting more than one report for deletion by checking boxes.
    - Clicking the old "Delete" link

    Clicking the delete button should prompt you to confirm. Clicking cancel
    should cancel.

    Clicking the delete button when no boxes are checked should trigger an
    alert asking you to select reports for deletion.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    This works really nicely, passes all tests and the QA script.

    There is one little thing to note: If you delete a single report
    using the option from the menu, the line you want to delete
    is highlighted in red. It would be nice to do that also for
    deleting multiple reports.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 300918e4886433f9f5b52779d8cf2027fcbdcb1a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jul 3 10:05:55 2013 -0400

    Bug 3134: add ability to selelct multiple reports to delete at once

    This patch adds the option to select multiple saved reports for
    deletion.

    To test you must have two or more saved reports to delete. Deletion
    should work properly when:

    - Selecting one report for deletion by checking the box.
    - Selecting more than one report for deletion by checking boxes.
    - Clicking the old "Delete" link

    Clicking the delete button should prompt you to confirm. Clicking cancel
    should cancel.

    Clicking the delete button when no boxes are checked should trigger an
    alert asking you to select reports for deletion.

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Functional tests pass, template tests pass.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reports/Guided.pm                               |   14 ++--
 .../en/modules/reports/guided_reports_start.tt     |   40 +++++++++--
 reports/guided_reports.pl                          |   11 +++-
 t/db_dependent/Reports_Guided.t                    |   69 ++++++++++++++++++--
 4 files changed, 112 insertions(+), 22 deletions(-)

hooks/post-receive
-- 
main Koha release repository