[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.04-3-g561c436

Tue Aug 27 20:21:25 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  561c436e933e6c1305808f13afd9cabf95e81e8e (commit)
       via  85420d30ecf1bdd62eca323c5703f684414953b3 (commit)
       via  9f5f05d40d2ee8a357d25472cd200a7f748de0e2 (commit)
      from  eec4b83d1c7ff372f7b8e1f261a45b5e6e2b9437 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 561c436e933e6c1305808f13afd9cabf95e81e8e
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Thu Jul 11 16:33:33 2013 +0200

    Bug 10543 - add mandatory subfield check to addorderiso2709.pl

    When adding orders from staged file, you can create one order per
    record using item form in the bottom of addorderiso2709.pl.  The
    form was missing checks of mandatory item fields; this patch
    adds those checks.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

    All 3 patches pass tests and QA script.

    Some additional notes on the test plan from the first patch:
    It took me a while to figure out a combination of subfields
    that would trigger the bug. I am not sure about the condition
    that transforms the input field into a textbox as it does
    not seem to happen for every field.

    What worked in the end was (MARC21):
    - $g cost, normal purchase price = mandatory
    - $h serial enumeration/chronolgy = optional, filled with
      text over 100 characters

    Checked for:
    - Adding items in cataloguing
      Was able to reproduce the problem, mandatory check works
      as expected.
    - Adding items from staged file in acq
      Was not able to trigger the problem, because we don't edit
      the item here, but mandatory check works as expected.
    - Addings items for serial subscriptions
      Was not able to trigger the problem, because we don't edit
      the items here, but mandatory check works better as before
      as missing mandatory fields are now highlighted and weren't
      before.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 2c7e1390b45e497676ea4f414520708577cf761a)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Couldn't reproduce using $i as in the test plan, but $o triggered the problem, which this patch series fix.

commit 85420d30ecf1bdd62eca323c5703f684414953b3
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Thu Jul 11 16:30:27 2013 +0200

    Bug 10543 - Unify item mandatory subfields check

    Use of CheckMandatorySubfields from cataloging.js
    everywhere an item cataloging form is checked for
    mandatory fields.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 0d4724e81b94b290a5b58970a8f59ebe8340f165)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Couldn't reproduce using $i as in the test plan, but $o triggered the problem, which this patch series fix.

commit 9f5f05d40d2ee8a357d25472cd200a7f748de0e2
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Jul 5 15:20:59 2013 +0200

    Bug 10543: fix false warnings from checks of mandatory item fields

    Under certain circumstances, when editing an item, you get a popup
    warning
      "1 mandatory fields empty (highlighted)".

    Even though all mandatory fields are filled in.

    This occurs when there is a field with a huge content (more than 100
    characters) that gets displayed in a textarea instead of input.

    This patch corrects the Javascript form check by using siblings().

    Also adds a more precise filter to find mandatory inputs because
    looking in full page may bring unwanted results.

    Test plan :
    - In a framework, make sure you have in item field :
      An optional subfield (without authorised value),
      then a mandatory subfield, then an optional subfield
      next to mandatory subfield
      For example : $i (optional), $r (mandatory) and $s (optional)
    - Open a biblio record and create a new item
    - Enter more than 100 characters in $i, fill $r and $s
    - Click "Add item"
    - Edit this item
    => You get a textarea for $i
    - Empty $s and Save
    => Without patch, you get a warning and form is not saved and you see that $s is yellow while it should be $r
    => With patch, form is saved
    - Re-edit this item
    - Empty $r and save
    => You get a warning and form is not saved

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Notes on last patch.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 651ea298ea90742a2c56bbb693a4fbbb0064d5b2)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Couldn't reproduce using $i as in the test plan, but $o triggered the problem, which this patch series fix.

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js   |   17 +++++++++++++++
 .../prog/en/modules/acqui/addorderiso2709.tt       |   13 +++++++++++
 .../prog/en/modules/acqui/neworderempty.tt         |    9 +------
 .../prog/en/modules/acqui/orderreceive.tt          |   15 ++----------
 .../prog/en/modules/cataloguing/additem.tt         |   22 ++++---------------
 .../prog/en/modules/serials/serials-edit.tt        |   14 +++++-------
 6 files changed, 46 insertions(+), 44 deletions(-)

hooks/post-receive
-- 
main Koha release repository