[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1002-g4287fd9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  4287fd9d1c3ae16a0496b6261de44642bc92ab9c (commit)
       via  7fa8e92e8e261f822b610da65b28a094e21e452c (commit)
       via  7a6bd88e497901bd7dc02e1964717da20313c0d8 (commit)
       via  68bf770f9238d6b05b9383e521969a6782b068d5 (commit)
      from  da40fe77fc471cfe8e797a7be5f87a506cf9d921 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4287fd9d1c3ae16a0496b6261de44642bc92ab9c
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Tue Jul 23 15:27:23 2013 +0200

    Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch
    
    Test plan :
    Check if the regression tests still works
    prove t/db_dependent/Branch.t
    t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
    t/db_dependent/Branch.t .. ok
    All tests successful.
    Files=1, Tests=36,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.00 csys =  0.16 CPU)
    Result: PASS
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    From the man page
    
    finsh()
    Indicate that no more data will be fetched from this statement handle
    before it is either executed again or destroyed.
    You almost certainly do not need to call this method.
    
    Adding calls to "finish" after loop that fetches all rows is a common
    mistake, don't do it, it can mask genuine problems like uncaught fetch errors.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 7fa8e92e8e261f822b610da65b28a094e21e452c
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Aug 28 14:24:34 2013 +0000

    Bug 10508: (follow-up) remove Perl 5.14 construct
    
    Also added parentheses to bare function calls.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 7a6bd88e497901bd7dc02e1964717da20313c0d8
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Tue Aug 27 10:29:42 2013 +1200

    Bug 10508: (follow-up) fix a typo
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Thx for the follow-up Chris!
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 68bf770f9238d6b05b9383e521969a6782b068d5
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Tue Jul 2 14:24:08 2013 +0200

    Bug 10508: add unit tests for C4::Branch
    
    Unit tests are wrap in a transaction.
    
    To test:
    prove t/db_dependent/Branch.t
    t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
    t/db_dependent/Branch.t .. ok
    All tests successful.
    Files=1, Tests=36,  1 wallclock secs ( 0.02 usr  0.02 sys +  0.13 cusr  0.01 csys =  0.18 CPU)
    Result: PASS
    
    http://bugs.koha-community.org/show_bug.cgi?id=10508
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Branch.pm            |   10 --
 t/db_dependent/Branch.t |  297 +++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 290 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
main Koha release repository