[koha-commits] main Koha release repository branch master updated. v3.14.00-62-gd536ed9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d536ed92fa6488a37a5e6325acb2b9b12f89ddaf (commit)
      from  cfa0dc1aedf3a280f98b9a1728853a6041f59af5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d536ed92fa6488a37a5e6325acb2b9b12f89ddaf
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Aug 21 10:53:20 2013 -0400

    Bug 2693: add ability to filter by reviewer name on tag review page
    
    If you want to filter results on the tags management page by the
    reviewer you have to know their borrowernumber. It would be better to be
    able to search by name, but in the meantime this patch adds an
    autocomplete widget to the form field so that you can do a name search
    and populate the field with the borrowernumber.
    
    To test you must have approved or rejected tags. From the tags review
    page (tags/review.pl), view all, approved, or rejected tags. Type a name
    in the "reviewer" form field in the left sidebar filter. You should get
    an autocomplete dropdown with names matching your search. When you
    select one the form field should be populated by the borrowernumber.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Patch works as described. I'm not sure whether or not it would be better
    to be able to search by name, as that would involve either choosing
    between names after applying the filter or showing any possible matches,
    so this seems fine.
    
    --
    
    Owen and I did observe that we were able to cause AJAX errors while
    using this autocomplete, but we are not 100% sure how we caused the error.
    In my case, I was able to occasionally cause it by typing in a name
    then backspacing rapidly. The ajaxError method is attached to every
    element in the DOM (yikes) so it's tough to say what exactly is the
    source of the error (which is signalled by a pop-up window that can be
    cancelled).
    
    The error is quite rare so I don't think it's necessarily a problem
    for us.
    
    One idea that Owen had was to remove the current error message, which
    is very unhelpful and replace it with an error like "Something went
    wrong. Try again."
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 circ/ysearch.pl                                        |    5 +++--
 koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt |   15 +++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository