[koha-commits] main Koha release repository branch master updated. v3.14.00-78-ga0b00e4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a0b00e4c8bd75a0557e487520fff5e2e39e10803 (commit)
       via  ce5ab3b31457793815a2f49bc8287fdcbd0dd3c5 (commit)
      from  d2d365ca830345b9a519158f6d735d2abd125380 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a0b00e4c8bd75a0557e487520fff5e2e39e10803
Author: Srdjan <srdjan at catalyst.net.nz>
Date:   Fri Nov 1 21:42:45 2013 +1300

    Bug 11077: Correct more warnings in C4/Auth.pm
    
    This gets rid of some more warnings.
    
    It also corrects a noisy ne condition.
        $userid = $retuserid if ( $retuserid ne '');
    became
        $userid = $retuserid if ( $retuserid );
    
    It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
    patch, while correcting the problems found.
    
    This includes:
        my $q_userid = $query->param('userid') // '';
    along with:
        my $s_userid = '';
    and:
        my $s_userid = $session->param('id') // '';
    Indentation does not reflect actual scoping.
    
    A missing system preference would have triggered a ubiquitous
    undef compare check failure message. This makes the flooding
    message more useful, so as to help correct it.
    The change to accomplish this was:
            my $pki_field = C4::Context->preference('AllowPKIAuth');
            if (!defined($pki_field)) {
                print STDERR "Error: Missing AllowPKIAuth System Preference!\n";
                $pki_field = 'None';
            }
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ce5ab3b31457793815a2f49bc8287fdcbd0dd3c5
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Oct 17 17:41:43 2013 -0700

    Bug 11077: remove uninitialized value $pki_field warning
    
    During login at the Staff interface you get warnings in the logs
    regarding an uninitialized value for the $pki_field variable.
    
    To test:
    - tail -f /path/to/your-intranet-logs
    - Point your browser to your staff login page
    - Login
    - Three warnings are showed
    - Apply the patch
    - Log out
    - Log in
    - No new warnings, and you can still log in.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com>
    
    Followed test plan; it works as advertised.
    Also works when I deleted AllowPKIAuth system pref.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm |   26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository